Mae-TM / TGPublic

A reverse-engineered copy of the public code for the current build of The Genesis Project, as of 16/4/23. For easier modding purposes.
GNU General Public License v2.0
2 stars 0 forks source link

Repo includes non-gpl material #2

Open magnusjjj opened 1 year ago

magnusjjj commented 1 year ago

The repository includes code from multiple unity store assets, and numerous third party libraries. The way the code is decompiled in also completely strips copyright notices inside of the code.

This was never an issue before, since the internal stance was that it wasn't open source, that the license document was just old and nobody had update it, becoming a joke internally among the team.

But, you might want to take a peek at remaking the repo with the proprietary code stripped and attribution given to the third party repositories.

The team doesn't want to take this further (I am for open sourcing it, by the by), and writing this completely on my own, but someone from the asset store might. This isn't a threat, nobody is planning to do anything about it I don't think, just a heads up.

gamefan131 commented 1 year ago

if your for open sourcing it why isnt it open source yet

magnusjjj commented 1 year ago

... Because it's not just my code, and I respect the other teammembers? The other's range from not wanting it, to wanting it, to wanting it but it being low on the priority scale.

In order for the code to be release, proprietary bought components need to be removed or replaced, and an asset inventory and relicensing to take place.

This repo needs to be taken down to be legal. You could try to reupload it after stripping the parts you are unsure of the license for. You can't just commit a delete of the assets, because the assets will still be accessible in the commit history. There is a reason why the project doesn't ship with a license file that says it's just GPL.

The decompilation also inherently strips copyright information and names of the authors by it's very nature, something that is straight up forbidden by the GPL and also copyright law.

Anyway, not stirring drama or calling you garbage or anything, just pointing out that your understanding of copyright law might get you in trouble from people outside the project. We won't go around spreading the information around, and honestly the reason I don't mention which unity assets are in question is so that it isn't googleable, though them searching for their namespace names would be.

Honestly internally people are just tired and I get the sense that people feel a bit violated, which isn't strange, but I get that's not your intention. You don't put this amount of effort in, in this particular way, in order to make people feel bad. It's obviously because you are excited and/or passionate and want to help other community members out. Which is cool, you might just want to try to figure out how you want to package it :).

Maybe you want to try to, hmm. Make it easier to decompile for others? There are command line tools for decompiling assemblies, like dnSpyEx. If you were to script it up, you could wind up with a simple tool to automatically decompile all the assemblies. This would make it so you don't need to redistribute the source code, just the tool :).

magnusjjj commented 1 year ago

(That would also make it so that the end user would get up to date source code automatically. Give it a lil think)

gamefan131 commented 1 year ago

i dont really understand this nor did i make the repo

Dapperbot28 commented 1 year ago

image

magnusjjj commented 1 year ago

i dont really understand this nor did i make the repo

Oh! TL;DR: The project bought things from the Unity store. We are not allowed to open source those. We need to replace those before making the rest open source. This has not been a problem before, because the entire team was OK with the game being closed and agreed on it.

gamefan131 commented 1 year ago

oh i guess that makes sense, also who the hell is that dapperbot fellow is he aslo a tgp person?

magnusjjj commented 1 year ago

He is not even in the discord server, so I would guess it's just someone popping in to call us nerds ;)

gamefan131 commented 1 year ago

well if they take down this and make like one with only rip instrutions that someone will finally make a mod with it, cause ive been waiting for someone to make a really cool mod but all the mods are just new weapons or clothes