Magisk-Modules-Repo / com.piyushgarg.rclone

253 stars 36 forks source link

rclone is zero bytes #106

Open MountainX opened 3 years ago

MountainX commented 3 years ago

I'm running Android 9 and Magisk 23.0. I installed rclone-mount via Magisk App.

When I run # rclone config the executable is not found.

sh: rclone: not found

So I searched for it and found it here:

/data/adb/modules/com.piyushgarg.rclone

However, it is 0 bytes. So apparently Magisk App did not install it correctly. In Magisk App, I removed it, installed it again, and rebooted. The rclone file is still 0 bytes, and I still get the error when I run # rclone config .

This is what the directory looks like:

1|:/data/ssh/root # ls -la /data/adb/modules/com.piyushgarg.rclone
total 244
drwxr-xr-x 3 root root  4096 2021-10-10 23:19 .
drwxr-xr-x 8 root root  4096 2019-04-16 23:02 ..
drwxrwxrwx 3 root root  4096 2021-10-10 23:19 .config
-rwxr-xr-x 1 root root 55256 2021-10-10 23:18 fusermount
-rwxr-xr-x 1 root root   306 2021-10-10 23:18 fusermount-wrapper.sh
-r-xr-xr-x 1 root root 67608 2021-10-10 23:18 inotifywait
-rw-r--r-- 1 root root 70696 2021-10-10 23:18 libandroid-support.so
-rw-r--r-- 1 root root   444 2021-10-10 23:18 module.prop
-rwxr-xr-x 1 root root     0 2021-10-10 23:18 rclone
-rwxr-xr-x 1 root root  4813 2021-10-10 23:18 rclonew
-rwxr-xr-x 1 root root 14543 2021-10-10 23:18 service.sh
-rw-r--r-- 1 root root     0 2021-10-10 23:18 skip_mount
-rwxr-xr-x 1 root root  2028 2021-10-10 23:18 syncd.sh

Any suggestions?

piyushgarg commented 3 years ago

check the errors during (re)installation.

MountainX commented 3 years ago

check the errors during (re)installation.

Do you see any problems on my end in this log? I see a few things like "curl failed to verify the legitimacy of the server" but I think that's an issue with the server...

As far as I can tell, the problem is the download server... but maybe I am misunderstanding it.

- Installing rclone-mount-v1.16(114).zip
Archive:  /storage/emulated/0/Download/rclone-mount-v1.16(114).zip
  inflating: module.prop
Archive:  /storage/emulated/0/Download/rclone-mount-v1.16(114).zip
  inflating: disable.sh
  inflating: manual.sh
  inflating: post-fs-data.sh
  inflating: service.sh
  inflating: system.prop
  inflating: install.sh
  inflating: module.prop
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                Dload  Upload   Total   Spent    Left  Speed

*******************************
*        rclone-mount         *
*        Magisk Module        *
+       rclone version
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: certificate has expired
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
+ 
*******************************
* Detected arch: arm64
+ Extracting package contents...
+ =====
+ =====
+ downloading rclone-arm64 to /data/adb/modules_update/com.piyushgarg.rclone/rclone
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: certificate has expired
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
gunzip: invalid magic
+ Extracting fusermount-arm64 to /data/adb/modules_update/com.piyushgarg.rclone/fusermount
+ Extracting lib-arm64/libandroid-support.so to /data/adb/modules_update/com.piyushgarg.rclone/libandroid-support.so
+ Extracting rclone-wrapper.sh script to /data/adb/modules_update/com.piyushgarg.rclone/rclonew
+ Extracting fusermount-wrapper.sh script to /data/adb/modules_update/com.piyushgarg.rclone/fusermount-wrapper.sh
+ Extracting syncd.sh script to /data/adb/modules_update/com.piyushgarg.rclone/syncd.sh
+ Extracting inotifywait-arm64 to /data/adb/modules_update/com.piyushgarg.rclone/inotifywait
- Setting permissions
✓ Now no need to reboot...
+ Attempting to mount your [Remotes]:
+ please wait...

'/sdcard/.rclone/rclone.conf' not found

Additional setup required...
Please run rclone config in su terminal
rmdir: '/data/adb/modules_update/com.piyushgarg.rclone': Directory not empty
- Done

After installing and rebooting, the directory contents are:

:/data/adb/modules/com.piyushgarg.rclone # ls -la
total 244
drwxr-xr-x 3 root root  4096 2021-10-11 12:33 .
drwxr-xr-x 8 root root  4096 2019-04-17 12:16 ..
drwxrwxrwx 3 root root  4096 2021-10-11 12:33 .config
-rwxr-xr-x 1 root root 55256 2021-10-11 12:14 fusermount
-rwxr-xr-x 1 root root   306 2021-10-11 12:14 fusermount-wrapper.sh
-r-xr-xr-x 1 root root 67608 2021-10-11 12:14 inotifywait
-rw-r--r-- 1 root root 70696 2021-10-11 12:14 libandroid-support.so
-rw-r--r-- 1 root root   444 2021-10-11 12:14 module.prop
-rwxr-xr-x 1 root root     0 2021-10-11 12:14 rclone
-rwxr-xr-x 1 root root  4813 2021-10-11 12:14 rclonew
-rwxr-xr-x 1 root root 14543 2021-10-11 12:14 service.sh
-rw-r--r-- 1 root root     0 2021-10-11 12:14 skip_mount
-rwxr-xr-x 1 root root  2028 2021-10-11 12:14 syncd.sh

rclone is 0 bytes again.

hitokirihahn commented 3 years ago

i've found temporary fix for this particular problem. Copy your downloaded .zip module to your PC and open it then edit file install.sh. Find line with "curl" part and add -k so it become "curl -k", save it then copy it back to your phone then flash it via magisk, it will work because mine's work.

MountainX commented 3 years ago

i've found temporary fix for this particular problem. Copy your downloaded .zip module to your PC and open it then edit file install.sh. Find line with "curl" part and add -k so it become "curl -k", save it then copy it back to your phone then flash it via magisk, it will work because mine's work.

That did not work for me. It solves part of the problem (the binary is no longer zero bytes), but the Magisk module still does not work.

hitokirihahn commented 3 years ago

i've found temporary fix for this particular problem. Copy your downloaded .zip module to your PC and open it then edit file install.sh. Find line with "curl" part and add -k so it become "curl -k", save it then copy it back to your phone then flash it via magisk, it will work because mine's work.

That did not work for me. It solves part of the problem (the binary is no longer zero bytes), but the Magisk module still does not work.

if the module didnt work then i dont know maybe something with your ROM, because mine work flawlessly.

MountainX commented 3 years ago

if the module didnt work then i dont know maybe something with your ROM, because mine work flawlessly.

I discussed this issue on XDA and Android Enthusiasts and multiple people (with more knowledge than me) said this module is broken.

So it's not just one person on one device. I tried this module on 2 different devices (running respectively LineageOS and stock Samsung firmware). It did not work on either device. Another person who had used this module successfully in the past looked into the issue and said he saw problems (beyond just the curl issue).

I got rclone mount working without this module, so I am not using this module. However, I may look into it more when I reinstall in the future. I would be interested to use this module if all the issues are fixed properly.

Mainly I just want to make sure anyone who cares about this module knows that the issues are not just one guy with one one device who gave up because curl did not work. That was not the case at all. I hope someone will properly maintain this module for the good of the community.

hitokirihahn commented 3 years ago

if the module didnt work then i dont know maybe something with your ROM, because mine work flawlessly.

I discussed this issue on XDA and Android Enthusiasts and multiple people (with more knowledge than me) said this module is broken.

So it's not just one person on one device. I tried this module on 2 different devices (running respectively LineageOS and stock Samsung firmware). It did not work on either device. Another person who had used this module successfully in the past looked into the issue and said he saw problems (beyond just the curl issue).

I got rclone mount working without this module, so I am not using this module. However, I may look into it more when I reinstall in the future. I would be interested to use this module if all the issues are fixed properly.

Mainly I just want to make sure anyone who cares about this module knows that the issues are not just one guy with one one device who gave up because curl did not work. That was not the case at all. I hope someone will properly maintain this module for the good of the community.

If something is wrong with the module then i dont know, i have no knowledge in this kind of thing. I have 3 different devices some using custom ROM and some using stock all of them works great with this module. Hope this module is properly maintained, it is a good module.

canwushuang commented 3 years ago

The gz package is broken due to the unexpected end of file.

MountainX commented 3 years ago

The gz package is broken due to the unexpected end of file.

Also, just to share additional info, Irfan Latif said the following about this module:

The LD_LIBRARY_PATH environment variable is not being set properly in the module, so the error occurs.