search

ManageIQ / manageiq-rpm_build

Code to build RPMs for ManageIQ appliances and container images
Apache License 2.0
10 stars 25 forks source link

Fix missing git_ref default value #422

Closed bdunne closed 1 year ago

bdunne commented 1 year ago

Using --build-type release depends on having a git_ref, the documented default was not implemented though. Error:

/build_scripts/lib/manageiq/rpm_build/build_copr.rb:68:in `spec_release': undefined method `empty?' for nil:NilClass (NoMethodError)
    from /build_scripts/lib/manageiq/rpm_build/build_copr.rb:62:in `update_spec'
    from /build_scripts/lib/manageiq/rpm_build/build_copr.rb:48:in `generate_spec_from_template'
    from /build_scripts/lib/manageiq/rpm_build/build_copr.rb:23:in `block in generate_rpm'
    from /build_scripts/lib/manageiq/rpm_build/build_copr.rb:22:in `chdir'
    from /build_scripts/lib/manageiq/rpm_build/build_copr.rb:22:in `generate_rpm'
    from bin/build.rb:51:in `<main>'
miq-bot commented 1 year ago

Checked commit https://github.com/bdunne/manageiq-rpm_build/commit/a1b5c1d2ae2facb4b1b714be28a8030dbf0adae2 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :+1:

bdunne commented 1 year ago

Backported to quinteros in 3d2fe796c37eb7cbfdc2d6f5555919b3308fe876

commit 3d2fe796c37eb7cbfdc2d6f5555919b3308fe876 (HEAD -> quinteros, upstream/quinteros)
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Wed Oct 4 14:24:21 2023 -0400

    Merge pull request #422 from bdunne/git_ref_default

    Fix missing git_ref default value

    (cherry picked from commit 896e28e78be16a81cd827e87fff857d2135e93a1)