Faster rpm build step 1

[jrafanie]

• Don't create .build-id artifacts
• Use built-in vcs exclusion for tar to also avoid .gitignore and other vcs files
• Curl and use the rpm 4.19.1 version of brp-strip for the xargs parallel processing and filtering - add our filtering patch for ruby and js on top of it.

Extracted from https://github.com/ManageIQ/manageiq-rpm_build/pull/436

generate_rpm is about 57 minutes, total build is 1 hour 15 minutes, roughly 30 minutes faster with these changes, of which nearly all of it is the brp-strip.

EDIT: The rpm metadata and contents looks to be just what we want changed. I've posted an update with screenshots from the pkgdiff -details -hide-unchanged beforeRPM afterRPM below.

[miq-bot]

Checked commits https://github.com/jrafanie/manageiq-rpm_build/compare/17fc2928884c322d4dbcaea1179cf98bf7469ca8~...43c8d638473b54d19cf5192ffd09fa3528b586be with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :trophy:

[Fryguy]

Awesome work @jrafanie !

LGTM

[Fryguy]

@jrafanie what is left to do here / why is this WIP?

[jrafanie]

@jrafanie what is left to do here / why is this WIP?

I'm reviewing the pkgdiff changes and will post here. I want to make sure the changes get all the things we want and not anything that might be regressions.

[jrafanie]

Looks like the python compiled programs changed slightly, which could be due to changes since they were run a different times or due to the strip changes. I guess we'll only know when we try them.

The vcs ignore files are removed as expected.

The venv provides sections looks to be unchanged, as desired... we'll tackle the pythondeps slowness elsewhere:

the build-id metadata is no longer packaged up:

[jrafanie]

ok @bdunne @Fryguy this is ready to go. I don't know how to test the brp-strip change. Technically, the 4.19 version brought no new dependencies into it so it should be fairly safe but clearly, it's changed so we should see if we can smoke test them.

[jrafanie]

@Fryguy let me know if there's anything else needed for this PR. I think it's ready to go and is limited to what we thought was safe to go with.

[jrafanie]

cc @bdunne (same as above... throw 🍅 )

[Fryguy]

Backported to quinteros in commit ed6f1e80e10631620dbfb284b81a81ae9b35e6ed.

commit ed6f1e80e10631620dbfb284b81a81ae9b35e6ed
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Thu Jan 18 14:37:21 2024 -0500

    Merge pull request #437 from jrafanie/faster_rpm_build_step1

    Faster rpm build step 1

    (cherry picked from commit 001b88f11e4e66ab1ef43cfa9e6a9f30b4f24257)