search

ManageIQ / manageiq-rpm_build

Code to build RPMs for ManageIQ appliances and container images
Apache License 2.0
10 stars 25 forks source link

Add opentofu-runner service #450

Closed agrare closed 6 months ago

agrare commented 8 months ago

Depends on:

Fryguy commented 8 months ago

Can you add this type of thing to the pluggability checklist as well?

agrare commented 8 months ago

I can add it but I'm not sure how pluggable the RPM build is or can be, not aware of any other aspect of it that we have overridden in plugins @bdunne ?

Fryguy commented 7 months ago

We have systemd units pluggable but it's pluggable generically by name (i.e. manageiq-providers-*) on the rpm side... Not sure how we can do it any differently

agrare commented 7 months ago

Right the opentofu-runner.service content is already defined in the provider repo, one thing that comes to mind is if we don't care about splitting up "core-services" and "gemset-services" we could just take %{_prefix}/lib/systemd/system/*.{service,target}

Fryguy commented 7 months ago

Yeah I'm not sure why we have them split other than the rpms themselves are split that way

miq-bot commented 6 months ago

Checked commit https://github.com/agrare/manageiq-rpm_build/commit/c3b59a94e86bdfc22f4012b5257b029a38b9b263 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cake:

Fryguy commented 6 months ago

I'm going to merge this on red. The failures are the new openssl issue, and @agrare has built this multiple times without failure, so I think it's good.