search

ManageIQ / manageiq-rpm_build

Code to build RPMs for ManageIQ appliances and container images
Apache License 2.0
10 stars 25 forks source link

Fix service ui productization symlinking #478

Closed Fryguy closed 2 months ago

Fryguy commented 4 months ago

The problem was that symlink_plugin_paths tries to symlink the client directory itself, but that directory already exists, so the ln_s call fails. However, it doesn't raise an exception and just moves on. I can't reuse that method without seriously rewriting it, so I wrote something custom. I do plan on writing something a bit more robust, but this should fix the problem at hand.

@bdunne Please review. cc @GilbertCherrie

Fryguy commented 4 months ago

Note I did not end-to-end test this with a productization plugin, because I'm not sure how. We missed this because it doesn't happen in the manageiq build, and only happens is downstream builds.

miq-bot commented 4 months ago

Checked commit https://github.com/Fryguy/manageiq-rpm_build/commit/85d63db0b2cba31cf388c66aeb142ba44e09a74a with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cake:

Fryguy commented 2 months ago

Backported to radjabov in commit 42cebeeae63ce7499b46cd280b43c64c7ec7b517.

commit 42cebeeae63ce7499b46cd280b43c64c7ec7b517
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Tue Sep 3 17:00:33 2024 -0400

    Merge pull request #478 from Fryguy/fix_service_ui_productization

    Fix service ui productization symlinking

    (cherry picked from commit 413dfbe20ef7529ca383a52fdf14e57eb22a17f4)