ManageIQ / manageiq-rpm_build

Code to build RPMs for ManageIQ appliances and container images
Apache License 2.0
10 stars 25 forks source link

Python requirements update #493

Closed kbrock closed 2 months ago

kbrock commented 2 months ago

Overview

Our current python packages are not compatible with the current ansible version installed (and/or the current python version).

CP4AIOPS-5619 / https://github.com/ManageIQ/manageiq-rpm_build/pull/495 was just focused on vmware and aws.

This provides all requirements.

Issues

In a container, not able to build gssapi (for pyspnego[kerberos], for ms/AD) This downloads many versions of gssapi but keeps failing. This may be because I'm doing this inside docker instead of at install time.

Reference

Dependencies brought up to date for:

Fryguy commented 2 months ago

This PR is fantastic - thanks for figuring this all out

Fryguy commented 2 months ago

@kbrock Recapping our private convo with @agrare , let's drop all of the ciscos from this list except for cisco/intersight.

Fryguy commented 2 months ago

This downloads many versions of gssapi but keeps failing.

What is the error you're getting? We might need to install a system package

kbrock commented 2 months ago

@Fryguy It looks like we are missing krb5-devel, but we install that. here

pip install 'pyspnego[kerberos]>=0.8.0'
Requirement already satisfied: pyspnego>=0.8.0 in /var/lib/manageiq/venv/lib/python3.9/site-packages (from pyspnego[kerberos]>=0.8.0) (0.11.1)
Requirement already satisfied: cryptography in /var/lib/manageiq/venv/lib64/python3.9/site-packages (from pyspnego>=0.8.0->pyspnego[kerberos]>=0.8.0) (43.0.1)
Collecting gssapi>=1.6.0 (from pyspnego[kerberos]>=0.8.0)
  Using cached gssapi-1.8.3.tar.gz (94 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [21 lines of output]
      /bin/sh: line 1: krb5-config: command not found

And truthfully, we should probably provide a minimum version on that library. I removed the minimum version hoping that the OS version would suffice.

Fryguy commented 2 months ago

I have a handful of Ruby comments but they can all be follow ups if needed.

kbrock commented 2 months ago

update:

kbrock commented 2 months ago

ok, so with our list of requirements, we only have 1 or 2 version comparisons to make.

I think having a very rudimentary system and displaying the work so a person can double check the work makes the most sense.

Fryguy commented 2 months ago

@kbrock This closed a lot of Mend issues 🎉 , but seems to have opened a few more. See https://github.com/ManageIQ/manageiq-rpm_build/issues?q=is%3Aissue+sort%3Aupdated-desc+updated%3A2024-09-18T02%3A50%3A00-04%3A00..2024-09-19+author%3Aapp%2Fmend-bolt-for-github