Mark-Eis / BitsnBobs

For General Bits and Bobs of Code
https://mark-eis.github.io/BitsnBobs/
Other
1 stars 0 forks source link

args before `...` don't need prefixing with`.` #71

Closed Mark-Eis closed 1 day ago

Mark-Eis commented 1 day ago

https://github.com/Mark-Eis/BitsnBobs/blob/bc21fcf5b068f73ce81f7aba777c15e7452220eb/R/catnames.R#L62

args before ... don't need prefixing with.

cat_names <- function(data, firstname = Firstname, surname = Surname, ..., .delimiter = ", ") {
    Firstname <- Surname <- NULL
    firstname = enquo(firstname)
    surname = enquo(surname)

    stopifnot(
        is.data.frame(data),
        !is.null(data[[as_name(firstname)]]), !is.null(data[[as_name(surname)]]),
        is.character(eval_tidy(firstname, data)), is.character(eval_tidy(surname, data))
    )

    pos <- eval_select(expr(c(...)), data)

    data[c(eval_select(expr(c(!!firstname, !!surname)), data), pos)] |>
        mutate(Names = paste(!!firstname, !!surname, collapse = .delimiter), .by = names(pos), .keep = "unused") |>
        unique() |>
        arrange(...)
}
Mark-Eis commented 1 day ago

d818b1e