search

MarsRaw / mars-raw-utils

Utilities for working with publicly available raw MSL & Mars2020 images
MIT License
45 stars 10 forks source link

mru calibrate -i *.png failes with "Instrument Unknown!" #14

Closed sschmaus closed 2 years ago

sschmaus commented 2 years ago

Running m20_hnav_calibrate -i *.png on previous versions on a folder with images performed calibration for all images in one go.

I expect the same behavior with the current mru calibrate -i *.png, however it throws the following error: 

mru calibrate -i *.png
*.png - Error: Instrument Unknown!        [ FAIL ]

At the moment I can only calibrate images if I include all filenames in the command, e.g.: mru calibrate -i .\HNM_0414_0703689998_109ECM_N0260001HELI05210_0000A0J02.png .\HNM_0414_0703689998_706ECM_N0260001HELI05228_0000LUJ01.png .\HNM_0414_0703689998_109ECM_N0260001HELI05210_0000A0J02.png

I would like to see the old behavior reintroduced, in case this isn't a bug. Calibrating the images one by one or adding all the filenames is quite tedious.

Specifications

kmgill commented 2 years ago

I'm not sure why the wildcard isn't working as I did not remove that. Will test

kmgill commented 2 years ago

Oh, when I updated the clap library I forgot to filter the args through wild. Whoops

kmgill commented 2 years ago

Changed from Cli::parse() to Cli::parse_from(wild::args) which will put the wildcard expansion back in there as expected. I will need to test on Windows

kmgill commented 2 years ago

Ok, works in Windows. Since this is a particularly annoying issue, I'll cut a 0.5.1 release for this and the previous bugfix from this morning.

sschmaus commented 2 years ago

Thanks for the quick fix and release!