search

MarsRaw / mars-raw-utils

Utilities for working with publicly available raw MSL & Mars2020 images
MIT License
45 stars 10 forks source link

msl-fetch, m20-fetch, nsyt-fetch not downloading images #26

Closed kmgill closed 1 year ago

kmgill commented 1 year ago

Appears to be a regression following PR. This could be why it's so fast.

mru msl-fetch -c MAST_RIGHT -s 3621
ID                                    Instrument      Sol    Image Date (UTC)     Image Date (Mars)           Site   Drive  Thumb   Present
3621MR1029060021702826C00_DXXX        MAST_RIGHT      3621   2022-10-13T17:27                                               No      No
3621MR1029060011702825C00_DXXX        MAST_RIGHT      3621   2022-10-13T17:27                                               No      No
3621MR1029050971702823C00_DXXX        MAST_RIGHT      3621   2022-10-13T17:09                                               No      No
3621MR1029050961702822C00_DXXX        MAST_RIGHT      3621   2022-10-13T17:09                                               No      No
...
3621MR1029050031702729C00_DXXX        MAST_RIGHT      3621   2022-10-13T16:38                                               No      No
3621MR1029050021702728C00_DXXX        MAST_RIGHT      3621   2022-10-13T16:38                                               No      No
3621MR1029050011702727C00_DXXX        MAST_RIGHT      3621   2022-10-13T16:37                                               No      No
3621MR1029030001702725C00_DXXX        MAST_RIGHT      3621   2022-10-13T16:35                                               No      No
100 images found
Runtime: 0.2674591s
mru m20-fetch -c MASTCAM -s 581
ID                                                     Instrument                Sol    Image Date (UTC)            Image Date (Mars)           Site   Drive  Thumb   Present
ZL0_0581_0718526624_586ECM_N0290000ZCAM05133_1100LMJ   MCZ_LEFT                     581 2022-10-08T18:52:12.835     Sol-00581M14:43:23.138          29      0 No      No
Error: File already exists on disk, skip it.
Runtime: 0.1053863s
mru nsyt-fetch -c ICC -s 1368
ID                                    Instrument      Sol    Image Date (UTC)     Image Date (Mars)           Thumb   Present
C000M1368_717988374EDR_F0000_0200M_   ICC             1368   2022-10-02T13:15     17:00:40.201                No      No
1 images found
Runtime: 0.0880787s
kmgill commented 1 year ago

Logic error in util.rs when determining whether to save given only_new bool and if file exists.

kmgill commented 1 year ago

Fixed a while ago