search

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

v4.0.0 UI lag #1777

Closed meow81 closed 7 years ago

meow81 commented 8 years ago

Since updating to v4.0.0, I'm experiencing a lot of lag with the UI catching up with the mouse cursor position and selectable elements of UI like play buttons when hovering over an album cover not showing or very delayed, volume slider delayed appearance, and menu items highlighted background color that shows when you are hovering over it very delayed.

The product unfortunately feels broken in this version. Should I try a reinstall? Let me know what additional info I can provide.

see the video for detail and pay attention to the mouse cursor: https://youtu.be/HfmpdkQb82o

forgot to show proof of the version in the video, but took a screen shot afterwards: image

My system info: Windows 10.0.14393 x64 Processor AMD FX-8370 Eight-Core Processor, 4000 Mhz, 4 Core(s), 8 Logical Processor(s) 8.00 GB RAM NVIDIA GeForce GTX 950

where is this in the FAQs? I looked, but it's not listed on that page.

If appropriate please attach the DEBUG information zip file that you can generate by following the instructions in the FAQ
(https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ)

MarshallOfSound commented 8 years ago

@meow81 Sorry that debug info FAQ appears to have vanished. I added it back in

https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ#how-do-i-generate-this-debug-zip-file

MarshallOfSound commented 8 years ago

Regardless however can you try clearing your cache completely.

Delete the %APPDATA%\Google Play Music Desktop Player folder 👍

madeleineostoja commented 8 years ago

I'm seeing a lot of UI lag and glitches with 4.0 as well. The glitches in particular make it really hard to use, the screen flashes white or tears.

Clearing application data didn't help.

On Macbook Pro 2015, MacOS Sierra latest. Debug info here: debug_info.zip

In the meantime is there a way to roll back to 3.x and turn off auto updates? In general it would be nice to opt-in to major version bumps (apologies if I just missed a setting for this somewhere).

meow81 commented 8 years ago

debug info: debug_info.zip

delete this folder? I didn't notice any difference after clearing the contents of the folder. image

MarshallOfSound commented 8 years ago

@meow81 Delete the entire Google Play Music Desktop Player folder.

meow81 commented 8 years ago

tried that. It didn't work.

Smashman commented 8 years ago

I am also seeing this issue on Mac OSX.

Could be related to the new UI changes made?

meow81 commented 8 years ago

just noticed the v4.0.1, updated, not sure if that has anything to do with this issue or not. Regardless, I cleared cache as instructed before and experience the same lag issues. Possibly a slight improvement, but the mouse cursor and UI are still not in sync. UI elements are jumpy and flashing under the mouse cursor and selections are still a bit behind where my mouse actually is.

boulund commented 8 years ago

I'm experiencing the same issues with the recent update. It wasn't perfect before, but the two most recent updates unfortunately really destroyed usability for me :(. Running Windows 10 Insider Preview on a Lenovo X1 Yoga (Core i7-6600U 2.81Ghz, 16GB RAM, 512GB SSD).

MarshallOfSound commented 8 years ago

Guys to determine where the issue is. Can you download raw Electron from here

https://github.com/electron/electron/releases/download/v1.4.3/electron-v1.4.3-win32-ia32.zip

And open the dev tools console and run the following command

window.location = "https://play.google.com/music/listen#/now"

Then play around and see if the UI lag is present.

boulund commented 8 years ago

Using the raw Electron release makes a WORLD of difference. Still not 100% perfect (just like most Electron-based apps I've used unfortunately--but probably not because of Electron in this case; the gplay website is slow for me as well), but a massive difference.

meow81 commented 8 years ago

agree with @boulund. It was night and day, only experienced a small delay once or twice, but noticeably better experience.

MarshallOfSound commented 8 years ago

Hm, without a device to reproduce the issue tracking down the lag will be tricky. Can someone run a CPU profile from dev tools and upload it here?

meow81 commented 8 years ago

I'm embarrassed to admit, but how do I do that? I will, just need a little guidance. This app is amazing and I'll do whatever to help out.

MarshallOfSound commented 8 years ago

Type DEV_MODE into the go to URL modal.

Relaunch GPMDP

Open dev tools with the standard chrome shortcut.

Click profiles

Click "start". Do some stuff for 30 seconds. Click "stop"

Upload it here

MarshallOfSound commented 8 years ago

@meow81 That profile appears to be from the webview not the main window. Can you upload a profile for the main window?

meow81 commented 8 years ago

I'm having trouble running the app to get dev mode. I'm not sure what I did originally was correct. Should I be using Electron?

MarshallOfSound commented 8 years ago

No you should be using GPMDP.

I'll try be more clean with the steps.

  1. Open GPMDP
  2. Use the shortcut "Control + Shift + G"
  3. Type in "DEV_MODE"
  4. Click "Let's Go"
  5. Relaunch GPMDP
  6. Use the dev tools shortcut "Control + Shift + I"
  7. Use the profiles tab to make a CPU profile
madeleineostoja commented 8 years ago

CPU-20161019T181635.cpuprofile.zip

Funnily enough the UI was reasonably smooth while recording that profile, maybe intermittent?

MarshallOfSound commented 8 years ago

@seaneking I can't see any obvious issues with that profile. Perhaps wait till it gets really bad and then start the profile 👍

boulund commented 8 years ago

Here's a profile from me. It was fairly slow during the recording, but probably not as slow as it has been at its worst before.

CPU-20161019T120723.zip

hydrocane commented 8 years ago

Here is another profile. The recording was the same as if I used the application normally with the lag.

CPU-20161019T062455.zip

I did find an error in the dev tools as well, not sure what it means:

"C:\Users\hydro\AppData\Local\GPMDP_3\app-4.0.1\resources\electron.asar\renderer\web-view\web-view.js:294 ::shadow pseudo-element is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details."

madeleineostoja commented 8 years ago

@hydrocane that's just a deprecation warning for the ::shadow selector, wouldn't effect UI lag.

meow81 commented 8 years ago

CPU-20161019T191543.zip

Okay got it this time. Have to say, running in DEV_MODE reduces much of the lag, so the capture won't be a good representation of what I experience running in a normal mode. When I switched back the lag returned to a pretty severe level.
Also, noticed that randomly now when I open the app it appears to just be displaying the web UI of google play music and no desktop app settings are present, not even the menu. Restarting the app fixes it.

image

MarshallOfSound commented 8 years ago

Also, noticed that randomly now when I open the app it appears to just be displaying the web UI of google play music and no desktop app settings are present, not even the menu. Restarting the app fixes it.

Getting the errors from console would help a lot with figuring out this issue. Someone weird is happening somewhere

lxcalghost commented 8 years ago

Screen glitches on MacOS: https://vid.me/hsPY

MarshallOfSound commented 8 years ago

@meow81 That log appears to indicate some kind of event loop, i.e. an event causing another event to be fired and react's event batching is working overtime to handle it.

It's gonna be hard to track this down 🍆

lucaseverett commented 8 years ago

In addition to the lag I'm seeing some other strange issues with version 4. I'm having frames drop. Animations appear to be around 10 to 20 frames per second. (I have an AMD RX 470 and had no issues with version 3.6.)

Also, when I'm in an album and hover over a song, the hover effect is showing on the wrong song. For example, when I hover over song #1 in an album, it shows the hover effect on #8.

In the following screenshot, I had my cursor over song #1.

hover

meow81 commented 8 years ago

Do we have any idea how widespread this? Is it possible to revert back to the previous version 3 until the issue is identified? I also realize you probably would like the logs additional data from impacted users on v4.

MarshallOfSound commented 8 years ago

Tbh, the easiest way for me to track this down is to get access to a device with the symptoms. I have tried all my devices and numerous VM's and none of them have the issue.

The analytics I have access to don't show any massive errors or a decrease in user count so it appears to not be very wide spread (you guys might just be unlucky). If anyone is OK with me using teamviewer and diving into the problem message me on Gitter and I'll try solve this for you guys 👍

lucaseverett commented 8 years ago

@MarshallOfSound What GPU do you have? It seems that all of us with issues are on an AMD GPU.

MarshallOfSound commented 8 years ago

@lucaseverett I'm on team green, but I know some people on AMD GPU's that aren't having this issue. Could be related though. not sure

meow81 commented 8 years ago

@MarshallOfSound I'm open to a teamviewer session so you can get some additional data.

hydrocane commented 8 years ago

@lucaseverett I am using an Intel HD GPU, so it may not be AMD related

MarshallOfSound commented 8 years ago

@meow81 Hit me up on Gitter and we can sort this out 👍

hydrocane commented 8 years ago

Is there anyway to prevent auto-update from occurring so I can stick with version 3.6.0?

MarshallOfSound commented 8 years ago

@hydrocane Technically yes, but if you do it, you will not receive any updates, even when I fix the issue (which I still have no idea what it is). Still need someone to let me have a look around on their machine so I can actually try to find out what's going on.

hydrocane commented 8 years ago

@MarshallOfSound If you have time now, you can take a look at my screen to sort it out.

MarshallOfSound commented 8 years ago

@hydrocane Hit me up on Gitter and we can try get it sorted 👍

hydrocane commented 8 years ago

@MarshallOfSound I appologize, I am new to Gitter, how do I do this?

meow81 commented 8 years ago

@MarshallOfSound I can do teamviewer some time this weekend, sunday for sure. where are you on gitter, I'm logged in there and only see a bunch of existing communities/groups with no search function.

shadeslain commented 8 years ago

I'm having a similar issue, instead of lag though my mouse just acts like it's jumping around on the UI, I'll click the volume meter and it will immediately jump from 0-100% constantly back and forth. Same thing when clicking on songs or play/pause controls(selection jumps around).

Happens both on 4.0.0 and 4.0.1, I've already deleted the GPMDP folder in appdata. Let me know if you need more screen captures.

OS: Microsoft Windows 10 Pro (x64) • CPU: Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz (2.81GHz) • Memory: 15.9 GiB • Storage: 56.2 GiB / 109.2 GiB (53.0 GiB Free) • VGA: Intel(R) HD Graphics 520

hydrocane commented 8 years ago

@shadeslain I had the same issue. What type of computer are you using. Apparently because my laptop has a touch screen, it causes the UI to glitch out. Marshallofsound is currently working on this with the electron people.

shadeslain commented 8 years ago

@hydrocane Dell Latitude E7470, mine is the Non-touch screen FHD variant.

madeleineostoja commented 7 years ago

Mine is a MacBook (no touch screen) as well, UI still laggy and glitches out.

Sp4rkR4t commented 7 years ago

Big lag and mouse over events triggering on items far away from the mouse, also resizing the window is causing many problems.

gpmd error

Windows 10 Pro, Intel CPU & nVidia GPU

donewert commented 7 years ago

Yes, I am having the same issue on my Macbook since upgrading to 4.0.x. The screen flashes way more than I could take, so I went back to 3.6 and its all good again.

MacBook Pro (Retina, 15-inch, Late 2013) 2.3 GHz Intel Core i7 16 GB 1600 MHz DDR3 NVIDIA GeForce GT 750M 2048 MB Intel Iris Pro 1536 MB

ericralph commented 7 years ago

I'm having major lag issues and sketchy, low-framerate animations. Dev mode seemed to significantly improve my experience, although it was still significantly laggy (albeit about as bad as the web UI).

Running Windows 10 w/ recent Anniversary Update on a Surface Pro 4 with a Core i5 and 8GB RAM. I've attached a CPU profile I took, it included some bad lag but I had to push to get it (normally the lag almost renders the app unusable from the moment after it starts).

I am also experiencing very odd UI flickering and instability, whereby any actions that require mouse hovering are incredibly inconsistent and barely functional (I can barely get the volume slider to appear and it mainly jumps between 0 and 100 if I manage to click it, similar experience with the three button menu for playlists and songs).

I should also note that this is minutes after a complete reinstall and removal of all AppData files. And oddly enough, performance is much better on my desktop PC. So definitely not a universal issue, for whatever reason.

CPU-20161024T160649.zip

MarshallOfSound commented 7 years ago

@ericralph You probably have the touch screen issue @hydrocane has

VenomXII commented 7 years ago

You closed my issue i opened, so here is a CPU profile, dev mode reduces the FPS drop and UI jitter enough so i can type this out. CPU-20161024T230557.zip Its really bad in normal mode, to the point where my cursor just starts moving around by its self reaaaaaly slowly. I'm open to a hangouts call and a Teamviewer session. i WFH most of the time so im available. Edit: I'm on a normal Desktop PC. Windows 10 home. I5-3570k, 24gb ram. GTX 660. I'm running Chrome and Wow at the same time. but there is still plenty of resources to go around. As soon as i force close the app, every returns to normal.