MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

v4.0.0 UI lag #1777

Closed meow81 closed 7 years ago

meow81 commented 8 years ago

Since updating to v4.0.0, I'm experiencing a lot of lag with the UI catching up with the mouse cursor position and selectable elements of UI like play buttons when hovering over an album cover not showing or very delayed, volume slider delayed appearance, and menu items highlighted background color that shows when you are hovering over it very delayed.

The product unfortunately feels broken in this version. Should I try a reinstall? Let me know what additional info I can provide.

see the video for detail and pay attention to the mouse cursor: https://youtu.be/HfmpdkQb82o

forgot to show proof of the version in the video, but took a screen shot afterwards: image

My system info: Windows 10.0.14393 x64 Processor AMD FX-8370 Eight-Core Processor, 4000 Mhz, 4 Core(s), 8 Logical Processor(s) 8.00 GB RAM NVIDIA GeForce GTX 950

where is this in the FAQs? I looked, but it's not listed on that page.

If appropriate please attach the DEBUG information zip file that you can generate by following the instructions in the FAQ
(https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ)

jostrander commented 7 years ago

@MarshallOfSound that last CPU Profile looks like the majority usage is with jQuery, or am I reading it wrong?

MarshallOfSound commented 7 years ago

@jostrander Yeah, that one appears to be mainly jQuery but it is within normal usage bounds. If you turn off "scroll lyrics automatically" in settings that usage will drop to 0.

VenomXII commented 7 years ago

after turning off that setting, do i need to restart the app?

MarshallOfSound commented 7 years ago

Nope, the jQuery animation will stop immediately

VenomXII commented 7 years ago

lag still exists :(

jostrander commented 7 years ago

Can you take another CPU profile without that enabled?

VenomXII commented 7 years ago

Here you go, i put it through its paces during this, lag was everywhere got my cursor doin the jitter thing again. CPU-20161024T235051.zip

MarshallOfSound commented 7 years ago

@VenomXII Are you sure the DEV_MODE improves the situation?

VenomXII commented 7 years ago

not really, its not much of improvement other than it lets me use my cursor while the program is minimized. if its in normal mode even when minimized or in the background my pc gets brought to a crawl.

MarshallOfSound commented 7 years ago

@VenomXII In task manager can you screen shot which process is using the CPU. Also screenshot the helper processes

VenomXII commented 7 years ago

If i force close the program and reopen it, it brings everything to a crawl/stop, then it comes back, its still in dev mode when i took these screenies. image image

MarshallOfSound commented 7 years ago

@VenomXII Out of interest and a completely wild guess, can you install Bonjour Print Services. Restart your computer, and see what happens πŸ‘

ericralph commented 7 years ago

It does look like GPMDP is indeed using a massive amount of CPU, albeit variably. Moments after opening (no music playing, haven't even opened the interface), it jumped to 100% CPU utilization and is hovering around 25-75% currently.

Dogodile commented 7 years ago

@MarshallOfSound Installing Bonjour Print Services and restarting resolved the issue here. I guess I never had it installed on my Surface but did on my desktop. Edit: My fix by restarting was short lived, laggyness is back. For now it seems rolling back is the best fix for me.

VenomXII commented 7 years ago

@MarshallOfSound I'd rather avoid installing anything apple related on my windows machine. and per @Dogodile it seemed to not work.

jostrander commented 7 years ago

@VenomXII I don't know if you read the same thing I did, but he said it resolved the issue. The bonjour print services are for chromecast and is a standard that Google decided to use.

And I didn't see the edit because I read this via email. My bad, but either way its for chromecast, even if its apple related.

MarshallOfSound commented 7 years ago

To stop the "I have this issue as well" spam I'm going to lock this conversation.

This will hopefully be fixed by Electron 1.5.0 and a Chromium version bump. As soon as I get my hands on a build for that version of Electron I'll link a build up here for you guys to test out.

If anyone has any magical insights on the cause or possible solutions for this issue please raise them in Gitter

I'll keep exploring possible causes and hopefully we'll get this fixed

MarshallOfSound commented 7 years ago

I have reports that 4.0.2 fixes this issue. Can you guys please test and confirm πŸ‘

lucaseverett commented 7 years ago

No change for me. I also deleted the "AppData\Roaming\Google Play Music Desktop Player" folder just to be safe.

I also did a clean install of Windows 10 and tried a different video card last week and there was no difference.

lucaseverett commented 7 years ago

Is there a way to force 3.6 to not update? I've been reinstalling 3.6 often because even though I don't manually update it eventually it updates by itself.

MiguelCTorres commented 7 years ago

Still bugged for me :( I deleted the Roaming GPMDP folder too. I can start music, but I cannot touch anything after press play button.

donewert commented 7 years ago

Yes. It is still flashing for me on MacBook Pro. However, it only seems to happen when on the laptop (retina) monitor. If I use an external monitor (HDMI/1080P) there don't seem to be any glitches at all.

The glitch I am seeing (again, only on the retina screen) is best described as a flash (turns white for a split second) in the screen right after the each background artist image is loaded. Just distracting is all. My Parallels Windows 10 VM works great.

Maybe another clue is on my Dell XPS 13 with a quad hd touch display, I see glitchy issues as well (mouse roll-over flashing). Maybe has something to do with ultra HD rez monitors?

Thank you!

meow81 commented 7 years ago

That's interesting, I'm using a 4k monitor with Windows recommended scaling of 150% turned on. Not sure if that helps. @MarshallOfSound, offer still on the table to do TeamViewer if you think that will help with troubleshooting.

lucaseverett commented 7 years ago

I also have a 4k monitor. As a test, I turned off display scaling and set it to 100% and all of the glitches go away. So this does appear to be an issue with scaling. Anything above a 1.0 scale factor glitches to the point of being unusable. With 3.6 it works at all scale factors.

meow81 commented 7 years ago

Good find @lucaseverett . I would expect it to work with scaling and hope the fix is prioritized (if it is related to that). Without scaling on 4k, some apps look awful or are really tiny, almost unusable.

EricPutney commented 7 years ago

1080p display here, changing scaling from 150% to 100% and signing out/in solved the problem completely for me!

ericralph commented 7 years ago

I also have display scaling set to 200% (Surface Pro 4 is nearly nonfunctional without scaling). I can also verify that installing the Bonjour Services did nothing noticeable to alleviate the problems I've been having.

On Fri, Nov 4, 2016 at 2:20 PM, DericMcDerpy notifications@github.com wrote:

1080p display here, changing scaling from 150% to 100% and signing out/in solved the problem completely for me!

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1777#issuecomment-258550440, or mute the thread https://github.com/notifications/unsubscribe-auth/ANP6WS_CRhAE_QAlVlIUoROB0GKSEJ9Yks5q66GXgaJpZM4KYGh2 .

Eric Ralph Science, Technology, & Society w/ Bioethics Emphasis | 2017 University of Puget Sound 3418 N Ferdinand St, Tacoma, WA 98407 eralph@pugetsound.edu 303.990.0977

MarshallOfSound commented 7 years ago

Raised https://github.com/electron/electron/issues/7882

Can you guys with the DPI issue test this build. https://mega.nz/#!eNdDBDCa!rPhFnzwTc5q3Soz8bkdBnmUNsLT6-Y3t4nuI4mkuJkY

donewert commented 7 years ago

Works the same here. Just tried it with no scaling, looks perfect. As soon as I scale to 150% the issue is back.

MarshallOfSound commented 7 years ago

Here is another one πŸ˜† This one theoretically should work πŸ‘

https://mega.nz/#!KM0izAra!cAUickZUiQEdMJy7XiDMFB7mPNOUAtE6aOkqPC7G9q8

donewert commented 7 years ago

Seems to have done the trick! Works great in Windows at 150% scaling. I look forward to trying it out on Mac.

Thank you!

MarshallOfSound commented 7 years ago

@donewert Although that one works it is not a fix. It is simply determining the exact version number in Electron that the issue started occurring. You're welcome to use it πŸ˜† but it isn't fixed yet πŸ˜†

donewert commented 7 years ago

Ah, gotcha. I will enjoy this special version on my PC then. :)

ericralph commented 7 years ago

I can verify that that modified build from the MEGA link works MUCH better. Still not exactly snappy, but it is very functional.

On Fri, Nov 4, 2016 at 9:28 PM, donewert notifications@github.com wrote:

Ah, gotcha. I will enjoy this special version on my PC then. :)

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1777#issuecomment-258590164, or mute the thread https://github.com/notifications/unsubscribe-auth/ANP6WYBnmdrKnhD7wwJOqZMAldzRhkGzks5q7AXmgaJpZM4KYGh2 .

Eric Ralph Science, Technology, & Society w/ Bioethics Emphasis | 2017 University of Puget Sound 3418 N Ferdinand St, Tacoma, WA 98407 eralph@pugetsound.edu 303.990.0977

lucaseverett commented 7 years ago

The mouse hover issues are gone in that build but the frame rate is still very low.

BalzGuenat commented 7 years ago

I have a 4K screen and the same issue. The build you just posted fixes the hover spasing but the minimize, maximize and close window buttons for the window stopped working. Framerate seems low (feeling <20). Pulling the window to the top edge to maximize still works. This is on Windows 10.

MarshallOfSound commented 7 years ago

Guys, please no one download and use that build. It was a hack job with badly compiled dependencies and some missing ones. It was PURELY FOR TESTING PURPOSES ❀️

If you want to revert to 3.6 and not get bugged by update notifications just change your hosts file to point update.gpmdp.xyz somewhere else temporarily. (This is not recommended as you won't get the potentially fixing future update)

I'm going to lock this up again to prevent spam. I'm hoping that the next Chromium bump will fix this for you guys. Stay tuned

MarshallOfSound commented 7 years ago

OK guys, new theory to test out, can you guys try this build ASAP and let me know if it works.

https://mega.nz/#!jRNyzDIB!dAAEyDCwUrwed2q-7RubOwwqxzhg3xSb6lOqxkx4I2c

EDIT: Bad build 😒

boulund commented 7 years ago

Sorry to say, it doesn't work well at all. Interface is laggy, mouse-over effects jump around all over the place.

MarshallOfSound commented 7 years ago

@boulund Can you try launching the .exe file from CMD like so.

"Google Play Music Desktop Player.exe" --enable-use-zoom-for-dfs=false -- --enable-use-zoom-for-dfs=false

EDIT: Uploading a new build now, I totally screwed up the other one

MarshallOfSound commented 7 years ago

https://mega.nz/#!WUkDSSya!PSuPahIn3CF8DIqA9XuqTlgLdysbo_PwJ8cg6bNLVkg

boulund commented 7 years ago

No mouse jitters! Performance is also good when not maximized. Still rather sluggish when maximized on my second monitor (2560x1440), but that might be because of my machine being a laptop with a weaker processor...

MarshallOfSound commented 7 years ago

@boulund Sweet, good to hear that I finally tracked it down πŸ˜†

Fix should go out next release πŸ‘ Until then feel free to use that build I just uploaded πŸ˜„

boulund commented 7 years ago

So, what was the cause?

Edit: nvm, see it now! :)

MarshallOfSound commented 7 years ago

@boulund Chromium 53 changed the way they handle display scaling on renderer windows. They automatically enabled the enable-use-zoom-for-dsf flag which apparently doesn't cope with webviews very well. Forcing that flag off fixed the issue πŸ‘

See the commit I just pushed for reference.

ericralph commented 7 years ago

At least for me, the 11/10 build was much worse than the previous one. Very, very laggy and could not even get the hover interaction aspects to work at all.

On Thu, Nov 10, 2016 at 5:27 AM, Samuel Attard notifications@github.com wrote:

@boulund https://github.com/boulund Chromium 53 changed the way they handle display scaling on renderer windows. They automatically enabled the enable-use-zoom-for-dsf flag which apparently doesn't cope with webviews very well. Forcing that flag off fixed the issue πŸ‘

See the commit I just pushed for reference.

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1777#issuecomment-259689499, or mute the thread https://github.com/notifications/unsubscribe-auth/ANP6WWPnpEMhjylgu6Z3Y7VFWbfwuBvLks5q8xvIgaJpZM4KYGh2 .

Eric Ralph Science, Technology, & Society w/ Bioethics Emphasis | 2017 University of Puget Sound 3418 N Ferdinand St, Tacoma, WA 98407 eralph@pugetsound.edu 303.990.0977

meow81 commented 7 years ago

this build worked for me: https://mega.nz/#!WUkDSSya!PSuPahIn3CF8DIqA9XuqTlgLdysbo_PwJ8cg6bNLVkg

wcomartin commented 7 years ago

anyway to make a MacOS Siera version of this build or is this going into the mainline soon?

donewert commented 7 years ago

I just upgraded to the latest (4.0.3) on Sierra. The problems persist there. Would be happy to test any builds if needed.

wcomartin commented 7 years ago

the latest build actually seems worse than 4.0.2, i cant even see the queue or the left nav anymore.

edit: works fine on my 1080p monitor, but the Macbook Pro Retina screen is a no go