search

MaterialDesignInXAML / MaterialDesignInXamlToolkit

Google's Material Design in XAML & WPF, for C# & VB.Net.
http://materialdesigninxaml.net
MIT License
15.03k stars 3.41k forks source link

Mahapps NumericUpDown has the same background color as the theme #1416

Closed ahmediddma closed 4 years ago

ahmediddma commented 4 years ago

Mahapps NumericUpDown has the same background color as the theme (white/dark) unlike the textbox that have transparent background

rgomez90 commented 4 years ago

@Keboo is this supposed to be this way or is this a bug?

Keboo commented 4 years ago

It is probably a bug. Right now we are in a weird place with the MahApps integration as they are making breaking changes to their theme brush names for their 2.0.0 release. My hope is to simply update to MahApps 2.0.0 and fix all of these brush resources. As for this specific issue I probably need to look a little closer at it. From the description it sounds like it is a bug since the NumericUpDown control is really designed to be similar to the text box.

ahmediddma commented 4 years ago

It is probably a bug. Right now we are in a weird place with the MahApps integration as they are making breaking changes to their theme brush names for their 2.0.0 release. My hope is to simply update to MahApps 2.0.0 and fix all of these brush resources. As for this specific issue I probably need to look a little closer at it. From the description it sounds like it is a bug since the NumericUpDown control is really designed to be similar to the text box.

you can test it by putting a textbox and Mah:NumericUpDown next to each other and changing the background color for the window to any color other than the default theme one

Keboo commented 4 years ago

Fixed by #1440

ahmediddma commented 4 years ago

@Keboo the validation works it show a red box around the controller but it's much bigger and the message doesn't show