MaterialDesignInXAML / MaterialDesignInXamlToolkit

Google's Material Design in XAML & WPF, for C# & VB.Net.
http://materialdesigninxaml.net
MIT License
15.13k stars 3.43k forks source link

MultiFloatingActionPopupBox has incorrect behavers (closing, click) (PopupBox) #2280

Open xsnakes opened 3 years ago

xsnakes commented 3 years ago

Version 4.0.0; MaterialDesignDemo.exe; net472.

(Style MaterialDesignMultiFloatingActionPopupBox, MaterialDesignMultiFloatingActionAccentPopupBox) PopupBox don't opened when cursor is hovered (maybe it is ok). PopupBox don't closed on second click (when opened). PopupBox has incorrect Ripple on second click (when opened) (incorrect location).

MultiFloatingActionPopupBox on Home page in Demo has this problem too. And empty project with MultiFloatingActionPopupBox has this problem too. Version 3.2.0 has only one this problem, with Ripple on closing.

https://user-images.githubusercontent.com/4363683/111642880-83ad6d00-880f-11eb-957d-a69422ee8957.mp4

Keboo commented 3 years ago

To your first point,

PopupBox don't opened when cursor is hovered

This is by design and was a breaking change with the 4.0.0 release. The default value of the PopupMode was changed from MouseOverEager to Click.

PopupBox don't closed on second click (when opened).

This appears to be a bug. I would expect that with PopupMode=Click that clicking on the button while it is opened should close it.

PopupBox has incorrect Ripple on second click

I don't think this is incorrect. The ripple is expected to trigger when the button is pressed. If you click on the PopupBox's toggle button to close it, I would expect the ripple to appear. This matches the Pressed state of the toggle button in the spec.

xsnakes commented 3 years ago

1. Open on click - is a good option! I missed this change.

3. Ripple on closing - is good. But Ripple in incorrect location when I close popup (location in right-top). It is right? Maybe Ripple must by in center of button or under Cursor? img

ProfBits commented 2 years ago

Can confirm both issues for Version 4.5.0 and net6.0