search

MaterialDesignInXAML / MaterialDesignInXamlToolkit

Google's Material Design in XAML & WPF, for C# & VB.Net.
http://materialdesigninxaml.net
MIT License
15.23k stars 3.44k forks source link

ScrollViewerAssist TreeView #3398

Closed jbooth88 closed 16 hours ago

jbooth88 commented 1 year ago

Bug explanation

I think the attached properties in MaterialDesignThemes.Wpf.ScrollViewerAssist do not apply to the TreeView control.

As an example, if I add the following code to the control template defined in MaterialDesignTreeView, setting IgnorePadding=False starts to have an effect:

wpf:ScrollViewerAssist.IgnorePadding="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(wpf:ScrollViewerAssist.IgnorePadding)}"

This might not be limited to TreeView? idk. MaterialDesignListBox doesn't appear to have them set in the control template either, so maybe this is by design?

Version

4.9

Keboo commented 1 year ago

This is likely just an oversight. It is difficult to keep up with all of the attached properties and making sure they are properly applied in all cases.

corvinsz commented 1 month ago

This issue has been open for a while, and from what I understand it isn't hard to fix. But just for me to clarify: is the fix for this issue to slap the AP wpf:ScrollViewerAssist.IgnorePadding="True" on every ScrollViewer inside of the MDIX Style Templates?

corvinsz commented 19 hours ago

@Keboo I think this issue can be closed because it was fixed in the PR #3717

Keboo commented 16 hours ago

ah thank you!