MaterialDesignInXAML / MaterialDesignInXamlToolkit

Google's Material Design in XAML & WPF, for C# & VB.Net.
http://materialdesigninxaml.net
MIT License
14.82k stars 3.4k forks source link

Fix 3568: Replace explicit AdornerDecorator.CacheMode with AP binding #3587

Closed nicolaihenriksen closed 2 weeks ago

nicolaihenriksen commented 3 weeks ago

Fixes #3568

A similar change was done to all other controls (see link in issue). The changes here seems like they may have been forgotten in the last PR (or not present at the time). There is still one left in the link below which I am a bit unsure about whether it needs the same fix or not. https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/blob/5dd9ca96ed81cb9c6abd79a6fa76a8266ada42d7/src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.ToolBar.xaml#L190-L193

I reproduced the issue by modifying the demo app, and the changes below (along with actually setting the AP at window-level; the workaround mentioned in the original issue from 2016) fixes the issue.