MaterialDesignInXAML / MaterialDesignInXamlToolkit

Google's Material Design in XAML & WPF, for C# & VB.Net.
http://materialdesigninxaml.net
MIT License
14.82k stars 3.4k forks source link

Align NumericUpDown style with other controls #3615

Closed michaelmairegger closed 4 days ago

michaelmairegger commented 1 week ago

This PR aligns the NumericUpDown style to the one of other controls (closes #3614)

Tasks

Breaking

Currently IncreaseContent and DecreaseContent are ignored since this two values should be the same as in TimePicker, not changable.

Should we use IncreaseContent and DecreaseContent or remove it. I would prefer to remove it and use it predefined as in TimePicker. If we ignore both properties, then we have to remove it from code before merging

old new
image image
image
image
image
image
nicolaihenriksen commented 1 week ago

Should we use IncreaseContent and DecreaseContent or remove it. I would prefer to remove it and use it predefined as in TimePicker. If we ignore both properties, then we have to remove it from code before merging

First of all, nice work!

Regarding your comment: I believe we should use them. We should default them to the PackIcon values they have currently, but I see no reason not to let someone manipulate them from the outside. For example if they want up/down arrows instead of +/-.

As for your comment about the TimePicker I think it would also make sense there to make the content configurable; thus could be considered a bug or a missing feature.

michaelmairegger commented 1 week ago

@nicolaihenriksen Ok, I will change the code that it will respect the user-configurated values for up/down

michaelmairegger commented 1 week ago

@nicolaihenriksen Done