search

MatthiasScholz / cos

Basic Cluster Orchestration Setup
GNU Lesser General Public License v3.0
34 stars 11 forks source link

Code Review 'f/terratest examples' (PR #68) #72

Closed ThomasObenaus closed 5 years ago

ThomasObenaus commented 5 years ago

This PR is intended to fix some issues from code review for PR #68 (after splitting the testfile).

ThomasObenaus commented 5 years ago

Hint: The TestNomadExample works only with the fix provided at 92feaad4a5d84c417c04dd81d0504ceb93766284 (which will be applied with PR #71).

To be able to run the test successfully already to check this PR you have to copy the files examples/nomad/sg_nomad_consul.tf and examples/nomad/sg_consul_nomad.tf to your local examples/nomad folder.

ThomasObenaus commented 5 years ago

Could you please provide some further insides about why major changes were made.

Can you give me a hint for which change you want to know more?

MatthiasScholz commented 5 years ago

Additionally a nomad test was added.