MatthiasScholz / cos

Basic Cluster Orchestration Setup
GNU Lesser General Public License v3.0
34 stars 11 forks source link

Expose asg name #74

Closed ElumalaiNarasimman closed 4 years ago

ElumalaiNarasimman commented 4 years ago

Expose the name of the public services auto scaling group.

ThomasObenaus commented 4 years ago

Hey @ElumalaiNarasimman,

before I can merge the PR: Can you please give a brief explanation why it is needed to expose the name of the public-services dc ASG? What is the Use-Case this change is needed for?

Furthermore I only will merge into master, that's why I changed the base branch for this PR to master.

ElumalaiNarasimman commented 4 years ago

in-order to use the nginx + feature to automatically discover the instances of auto scaling groups. in our use case, nginx-asg-sync is used to discover the instances of public services auto-scaling group and that route the requests to public services instances and blocked noauth for internet.

ThomasObenaus commented 4 years ago

Ok @ElumalaiNarasimman understood the problem. I'll merge the PR. But for me the solution sounds a bit odd and has drawbacks especially regarding loadbanacing.

pcc_loadbalancing

So I would suggest to have a look at the solution with an internal ALB.