MazinLab / MKIDPipeline

The MKID Data Pipeline
http://web.physics.ucsb.edu/~bmazin/
6 stars 3 forks source link

added full test #101

Open michaelarena opened 3 months ago

codecov[bot] commented 3 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

ld-cd commented 3 months ago

Whoops those shouldn't pass...

ld-cd commented 3 months ago

Ah

ld-cd commented 3 months ago

https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-large-files-on-github#removing-files-from-a-repositorys-history

ld-cd commented 3 months ago

Free tier won't be good enough here, I'll need to generate bin files on the fly I think :(

ld-cd commented 3 months ago

Running with the full dataset we still get the same error we get with this test and the reduced dataset:

2024-08-25 14:38:53 mkidpipeline.steps.flatcal  :INFO     (make_spectral_cube:362[pid=3898002]) Loaded 850.0 nm spectral cube
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/mkidpipe.py", line 175, in <module>
    sys.exit(mainmain())
             ^^^^^^^^^^
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/mkidpipe.py", line 172, in mainmain
    return main(args)
           ^^^^^^^^^^
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/mkidpipe.py", line 159, in main
    pipe.PIPELINE_STEPS[step].fetch(getattr(outputs, f"{step}s"))
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 564, in fetch
    f.run()
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 125, in run
    self.load_flat_spectra()
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 145, in load_flat_spectra
    self.make_spectral_cube()
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 363, in make_spectral_cube
    cps_cube_list[:, :, :, w_idx] = hdul['SCIENCE'].data
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
ValueError: could not broadcast input array from shape (0,140,146) into shape (6,140,146)
ld-cd commented 3 months ago

mkidpipe_2024-08-25_1207.log

ld-cd commented 2 months ago

We now have a binfile generator https://mazinlab.github.io/binney/binney.html#BinSerializer