search

MehVahdJukaar / Moonlight

GNU General Public License v3.0
53 stars 29 forks source link

Vivecraft compatibility #11

Closed Techjar closed 3 years ago

Techjar commented 3 years ago

Hi, I'm one of the Vivecraft devs. Your mod currently crashes when loaded with Vivecraft, due to this mixin failing as it conflicts with one of our patches: https://github.com/MehVahdJukaar/Selene/blob/master/src/main/java/net/mehvahdjukaar/selene/mixins/FirstPersonRendererMixin.java Since it appears to just be a handler for first person animations, which I don't think would look right in VR anyways, it'd probably be fine to just disable it when Vivecraft is detected or otherwise have the mixin not crash the game when it fails.

MehVahdJukaar commented 3 years ago

Hi, so I think I'll add a mixin config next time I update the mod so one has more control over them and add an additional check for your mod. However I might not release this update right away so I think a very easy patch you could do in the mean time (if you plan on releasing this before I update) is to simply add an if (false) { this.renderItem( ); this.renderItem( ) } to that method so mixin will be injected but never called

Techjar commented 3 years ago

Hmm, good to know, I'll have to try that when I get the chance. We're probably not going to release an update right away either though, so as a temporary workaround I've just been telling people to remove the mixin manually from the json file inside the jar. Also, thanks for the quick response! :)

MehVahdJukaar commented 3 years ago

Ok I made that moxin non required so it shouldn't crash when failing to apply