MehVahdJukaar / Moonlight

GNU General Public License v3.0
48 stars 26 forks source link

[🐞]: Level must be either ServerLevel or ClientLevel #247

Open Skullians opened 3 weeks ago

Skullians commented 3 weeks ago

BEFORE CONTINUING:

Version-Loader

1.19.2-fabric

Moonlight Lib Version

moonlight 1.19.2 2.3.6

Issue Detail

I've seen this happen a couple times. We use neruina to fix ticking entities / players and whatnot, and we frequently get a notification from neruina relating to the FakePlayerManager of Moonlight.

Log Attachment

latest.log java.lang.IllegalArgumentException: Level must be either ServerLevel or ClientLevel at net.mehvahdjukaar.moonlight.api.util.fake_player.FakePlayerManager.get(FakePlayerManager.java:34) at net.mehvahdjukaar.moonlight.api.util.fake_player.FakePlayerManager.get(FakePlayerManager.java:41) at net.mehvahdjukaar.moonlight.api.util.fake_player.FakePlayerManager.getDefault(FakePlayerManager.java:56) at net.mehvahdjukaar.supplementaries.common.entities.SlingshotProjectileEntity.method_24920(SlingshotProjectileEntity.java:170) at net.minecraft.class_1676.method_7488(class_1676.java:153) at net.mehvahdjukaar.moonlight.api.entity.ImprovedProjectileEntity.method_5773(ImprovedProjectileEntity.java:219) at net.mehvahdjukaar.supplementaries.common.entities.SlingshotProjectileEntity.method_5773(SlingshotProjectileEntity.java:201) at net.minecraft.class_3218.method_18762(class_3218.java:712) at net.minecraft.class_1937.mixinextras$bridge$accept$207(class_1937.java) at com.bawnorton.neruina.handler.TickHandler.safelyTickEntities(TickHandler.java:92) at net.minecraft.class_1937.wrapOperation$epg000$neruina$catchTickingEntities$notTheCauseOfTickLag(class_1937.java:14067) at net.minecraft.class_1937.method_18472(class_1937.java:466) at net.minecraft.class_3218.method_31420(class_3218.java:371) at net.minecraft.class_5574.method_31791(class_5574.java:54) at net.minecraft.class_3218.method_18765(class_3218.java:339) at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:875) at net.minecraft.class_3176.method_3813(class_3176.java:289) at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:819) at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:665) at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) at java.base@17.0.9/java.lang.Thread.run(Thread.java:840)

OPTIONAL: To Produce

1) Download supplementaries and moonlight api 2) see the error ocassionally. not been able to always reproduce it.

OPTIONAL: Which mods are affected?

supplementaries not entirely sure

Skullians commented 3 weeks ago

I have just found https://github.com/MehVahdJukaar/Supplementaries/issues/515 but we don't use TabTPS.

MehVahdJukaar commented 3 weeks ago

Happens when a slingshot projectile is fired. It's somehow getting passes a non vanilla level somehow. Would be useful finding the mod that allows this to happen as doesn't on its own

Skullians commented 3 weeks ago

Oh man. I'll look into it if I have the time but we have over 250 mods