Mermaid-Chart / issue-tracker

Other
10 stars 1 forks source link

Renderer not working #17

Closed bradranks closed 11 months ago

bradranks commented 1 year ago

Describe the bug Cannot use renderer To Reproduce Add renderer as first line:

%%{init: {"flowchart": {"defaultRenderer": "elk"}} }%%

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior render the chart using ELK

Screenshots If applicable, add screenshots to help explain your problem.

Screenshot 2023-09-15 at 10 33 28 AM

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context It worked yesterday.

jgreywolf commented 1 year ago

Can you share with me the full code of a diagram that is not working as expected? When I add init to use the elk renderer I am not seeing the same error.

However, in looking at your screenshot further I am able to reproduce the error you are seeing if I do not add a newline between the init statement and the diagram type definition (graph/flowchart).

bradranks commented 1 year ago

Hi Justin,

Thanks for looking into this, this is invaluable to us in fixing these spaghetti monster maps from clients. You should see some of the maps we get! Example: [image: image.png]

Here is the code I was using:

=======

%%{init: {"flowchart": {"defaultRenderer": "elk"}} }%%

graph LR

subgraph Marketing SAP_Marketing_Cloud_B2B end subgraph Data_Sources Other_Leads NiceInContact Dista Sellout_Data_Amazon_Etailer_ME end subgraph Master_Data S4HC end

subgraph Analytics Snowflake Sigma Domo Big_Query GravityHub end

subgraph Authentication Gigya OKTA end

subgraph CRM C4C end

subgraph E-Commerce PCA_Magento_B2B-->VTEX Shopify-->VTEX Pro_Shopify-->VTEX Avalara-->VTEX D2C_Pro-->VTEX Virtex-->VTEX end

subgraph Learning_and_Support Litmos PCA_Magento_B2B-->Litmos VTEX-->Litmos PCA_Academy-->PCA_Magento_B2B Salescore_Chat_bot_Margo-->PCA_Magento_B2B PCA_Magento_B2B-->S4HC S4HC-->Litmos end

subgraph Supply_Chain_and_Inventory S4HC-->VTEX S4HC-->C4C S4HC-->Snowflake S4HC-->Sigma S4HC-->Domo S4HC-->Litmos S4HC-->SAP_Marketing_Cloud_B2B S4HC_Supply_Chain-->S4HC SEI_Data_flow_tool-->S4HC end

subgraph CRM Gigya-->VTEX Gigya-->BlueConic OKTA-->Gigya C4C-->SAP_Marketing_Cloud_B2B C4C-->S4HC NiceInContact-->C4C Other_Leads-->C4C Dista-->C4C end

subgraph Analytics Snowflake-->Sigma Snowflake-->Domo BlueConic-->Snowflake BlueConic-->Sigma BlueConic-->Domo GravityHub-->Snowflake Advertising_and_Social_Media_Data-->BlueConic Sellout_Data_Amazon_Etailer_ME-->BlueConic end

subgraph Marketing Salesforce_Marketing_Cloud_DTC-->GravityHub Physician_Locator-->Storepoint end

=======

There is also another similar ticket opened with this test code:

======= %%{ init: { "flowchart": { "defaultRenderer": "elk" } }}%%

flowchart TB

subgraph test node end

Link to other ticket: https://github.com/mermaid-js/mermaid-live-editor/issues/1305

Thanks again!

Brad

Brad Ranks Solutions Architect

DIRECT: 480-577-2723 |

Technically, The Best!

--

CONFIDENTIALITY NOTICE: This email is property of Digital, LLC and is intended for the named person's use only. The statements and any attachments or information disclosed in this email may be confidential, proprietary or legally privileged. If you are not the intended recipient, you may not directly or indirectly disclose, copy, distribute, print or otherwise use the contents of the information included in this email. No confidentiality or privilege is waived or lost by any transmission errors. If you have received this email in error, please immediately notify Digital and destroy all electronic and hard copies of the communication, including any attachments. This email is not an offering and is not intended to be used for investment advice.

On Fri, Sep 22, 2023 at 10:14 AM Justin Greywolf @.***> wrote:

Can you share with me the full code of a diagram that is not working as expected? When I add init to use the elk renderer I am not seeing the same error.

However, in looking at your screenshot further I am able to reproduce the error you are seeing if I do not add a newline between the init statement and the diagram type definition (graph/flowchart).

— Reply to this email directly, view it on GitHub https://github.com/Mermaid-Chart/issue-tracker/issues/17#issuecomment-1731770301, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABP7HHYHLCNQRMPGM34WMFDX3XBPZANCNFSM6AAAAAA42EC2CI . You are receiving this because you authored the thread.Message ID: @.***>

jgreywolf commented 1 year ago

FYI - I have not forgotten this. I am still working on tracking the source of this down, and will update early next week

Justin Greywolf Software Engineer - Mermaid Chart https://www.mermaidchart.com

On Fri, Sep 22, 2023 at 10:25 AM bradranks @.***> wrote:

Hi Justin,

Thanks for looking into this, this is invaluable to us in fixing these spaghetti monster maps from clients. You should see some of the maps we get! Example: [image: image.png]

Here is the code I was using:

=======

%%{init: {"flowchart": {"defaultRenderer": "elk"}} }%%

graph LR

subgraph Marketing SAP_Marketing_Cloud_B2B end subgraph Data_Sources Other_Leads NiceInContact Dista Sellout_Data_Amazon_Etailer_ME end subgraph Master_Data S4HC end

subgraph Analytics Snowflake Sigma Domo Big_Query GravityHub end

subgraph Authentication Gigya OKTA end

subgraph CRM C4C end

subgraph E-Commerce PCA_Magento_B2B-->VTEX Shopify-->VTEX Pro_Shopify-->VTEX Avalara-->VTEX D2C_Pro-->VTEX Virtex-->VTEX end

subgraph Learning_and_Support Litmos PCA_Magento_B2B-->Litmos VTEX-->Litmos PCA_Academy-->PCA_Magento_B2B Salescore_Chat_bot_Margo-->PCA_Magento_B2B PCA_Magento_B2B-->S4HC S4HC-->Litmos end

subgraph Supply_Chain_and_Inventory S4HC-->VTEX S4HC-->C4C S4HC-->Snowflake S4HC-->Sigma S4HC-->Domo S4HC-->Litmos S4HC-->SAP_Marketing_Cloud_B2B S4HC_Supply_Chain-->S4HC SEI_Data_flow_tool-->S4HC end

subgraph CRM Gigya-->VTEX Gigya-->BlueConic OKTA-->Gigya C4C-->SAP_Marketing_Cloud_B2B C4C-->S4HC NiceInContact-->C4C Other_Leads-->C4C Dista-->C4C end

subgraph Analytics Snowflake-->Sigma Snowflake-->Domo BlueConic-->Snowflake BlueConic-->Sigma BlueConic-->Domo GravityHub-->Snowflake Advertising_and_Social_Media_Data-->BlueConic Sellout_Data_Amazon_Etailer_ME-->BlueConic end

subgraph Marketing Salesforce_Marketing_Cloud_DTC-->GravityHub Physician_Locator-->Storepoint end

=======

There is also another similar ticket opened with this test code:

======= %%{ init: { "flowchart": { "defaultRenderer": "elk" } }}%%

flowchart TB

subgraph test node end

Link to other ticket: https://github.com/mermaid-js/mermaid-live-editor/issues/1305

Thanks again!

Brad

Brad Ranks Solutions Architect

DIRECT: 480-577-2723 |

Technically, The Best!

--

CONFIDENTIALITY NOTICE: This email is property of Digital, LLC and is intended for the named person's use only. The statements and any attachments or information disclosed in this email may be confidential, proprietary or legally privileged. If you are not the intended recipient, you may not directly or indirectly disclose, copy, distribute, print or otherwise use the contents of the information included in this email. No confidentiality or privilege is waived or lost by any transmission errors. If you have received this email in error, please immediately notify Digital and destroy all electronic and hard copies of the communication, including any attachments. This email is not an offering and is not intended to be used for investment advice.

On Fri, Sep 22, 2023 at 10:14 AM Justin Greywolf @.***> wrote:

Can you share with me the full code of a diagram that is not working as expected? When I add init to use the elk renderer I am not seeing the same error.

However, in looking at your screenshot further I am able to reproduce the error you are seeing if I do not add a newline between the init statement and the diagram type definition (graph/flowchart).

— Reply to this email directly, view it on GitHub < https://github.com/Mermaid-Chart/issue-tracker/issues/17#issuecomment-1731770301>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABP7HHYHLCNQRMPGM34WMFDX3XBPZANCNFSM6AAAAAA42EC2CI>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Mermaid-Chart/issue-tracker/issues/17#issuecomment-1731783135, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJILOFHGRE2PIVUZIIXTDX3XCXJANCNFSM6AAAAAA42EC2CI . You are receiving this because you commented.Message ID: @.***>

Penagwin commented 11 months ago

Is there any update on this? My chart was working in the live editor a few weeks ago (I don't know the version sorry), but it's broken now (10.5.0).

Mine also uses nested subgraphs. It fails to render with elk. It does render with the default renderer.

jgreywolf commented 11 months ago

This is still being looked at. I do not have any other update yet

jgreywolf commented 11 months ago

Looks like there is a bug in the elk renderer in mermaidJs. We are looking into that angle now and hope to have an update by Monday

jgreywolf commented 11 months ago

@bradranks I am happy to tell you that the elk renderer bug has been fixed. See screenshot below:

image

knsv commented 11 months ago

@bradranks This was a bug in Mermaid, which has been fixed in the latest version. I am closing this issue. Please reopen if you still are having issues.