search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.04k stars 4.92k forks source link

Porting to Safari Web Extension (Safari 14) #8879

Open winzig opened 4 years ago

winzig commented 4 years ago

Safari 14 (in preview mode now) supports the WebExtension standard. Is it possible to port Metamask to work as a Safari extension now?

Meet Safari Web Extensions - WWDC session about the new capability, with links to supporting documentation.

TechCrunch: Apple will let you port Google Chrome extensions to Safari

whymarrh commented 4 years ago

Refs #5173

Yes, we're quite aware (and excited!) about this development. We will be looking into a Safari port.

xlab commented 4 years ago
Screenshot 2020-09-18 at 13 11 02

Aaannd.. it's available

userx6345 commented 4 years ago

Any update on this? I've managed to ween myself off Chrome on Mac for everything other than MetaMask

bfish645 commented 4 years ago

Agreed this would be awesome. It's the only thing I use chrome for on a mac.

vast-z commented 3 years ago

I look forward to this version very much, this is almost the only reason I use chrome

rheeger commented 3 years ago

2021 bumping this feature request. Please port! Happy to contribute to the effort.

lucasverra commented 3 years ago

supporting the motion right here, safari is a breeze to use

xlab commented 3 years ago

MetaMask for Safari 14 https://github.com/InjectiveLabs/metamask-extension/releases/tag/v9.0.5-safari

πŸŽ‰πŸ˜‹

Screenshots

app_2880_1800 conn_req_2880_1800 balances_2880_1800
vast-z commented 3 years ago

Thank you very much for this version, but I have encountered some problems, the page opens in white

2021εΉ΄2月12ζ—₯ 上午10:29，Max Kupriianov notifications@github.com ε†™ι“οΌš

MetaMask for Safari 14 https://github.com/InjectiveLabs/metamask-extension/releases/tag/v9.0.5-safari https://github.com/InjectiveLabs/metamask-extension/releases/tag/v9.0.5-safari πŸŽ‰πŸ˜‹

Screenshots

https://user-images.githubusercontent.com/477998/107723741-12037000-6cf3-11eb-8d28-5b7cd436e08d.png https://user-images.githubusercontent.com/477998/107723754-19c31480-6cf3-11eb-802f-486686d9b487.png https://user-images.githubusercontent.com/477998/107723761-20518c00-6cf3-11eb-9398-801cb6bc89fa.png β€” You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/8879#issuecomment-777927719, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGOM3FBL6RIWD5P3XY5O633S6SHATANCNFSM4ONZCBXA.

winzig commented 3 years ago

I'm confused, is InjectiveLabs officially related to MetaMask in some way? I.e. is this the official build of MetaMask for macOS?

xlab commented 3 years ago

I'm confused, is InjectiveLabs officially related to MetaMask in some way? I.e. is this the official build of MetaMask for macOS?

InjectiveLabs is not officially related to MetaMask. We just provided the necessary patch to make it work for now, then it's MetaMask's responsibility to release the extension to Apple's store. This is how opensource works - we fixed problem (to some extent) for our stuff and glad to share the solution with the upstream and the world.

P.S. hardware wallets require a little bit more work, I'm not sure if we will take this now.

vast-z commented 3 years ago

I ran into this problem [Error] Failed to load resource: the server responded with a status of 429 (Too Many Requests) (store, line 0) I don’t know if there is a solution. can it be listed on Apple? Finally, thank you very much for your work

no-nice-username commented 3 years ago

Any updates on this?

crisog commented 3 years ago

@Gudahtt any ETA on this?

koraykoska commented 3 years ago

+1

pepinto commented 3 years ago

+1

lion24 commented 3 years ago

Hi there,

That would be nice to open a PR linked to this issue with the code change if we want things to move further.. I'm not sure referencing a link to a release through an external repo is the right approach ;)

Cheers.

dvcrn commented 3 years ago

There are build instructions available in https://github.com/InjectiveLabs/metamask-extension/blob/safari-extension/docs/build-for-safari.md, so you don't need to install a build that you don't trust

lion24 commented 3 years ago

I know, that was not my point. My point was: it would make sense to open a pull request with the code require to make it works on Safari. This is how open-source is suppose to work, you have an enhancement, you open a PR with the code linked and a nice description a push to have it merge such that it will be included in the metamask code base.

Because like that I'm 1000% sure this code will never been merge since this this ticket is only an issue referencing code from another repo. The metamask developpers would never care about that...

If you want I can have a look to do it...

Cheers

dvcrn commented 3 years ago

But @xlab made a pull request πŸ˜„ https://github.com/MetaMask/metamask-extension/pull/10426

lion24 commented 3 years ago

But @xlab made a pull request smile #10426

Oh my bad.. Sorry I didn't saw this :D All good then :)

Cheers

Dag0d commented 3 years ago

any news here?

dvcrn commented 3 years ago

With the change to metamask for chrome today, and the fully working connection through to Ledger Live Desktop, I'm wondering if adding hw wallet support to the @xlab's pr got easier.

xlab commented 3 years ago

With the change to metamask for chrome today, and the fully working connection through to Ledger Live Desktop, I'm wondering if adding hw wallet support to the @xlab's pr got easier.

Nice find, I'll take a look

xlab commented 3 years ago

@dvcrn it would be working almost perfectly, except for one small detail...

Screenshot 2021-06-05 at 17 08 20

I'm not sure why this bridge is hosted on a separate domain.

banishee commented 3 years ago

MetaMask for Safari 14 https://github.com/InjectiveLabs/metamask-extension/releases/tag/v9.0.5-safari

πŸŽ‰πŸ˜‹

Screenshots

app_2880_1800 conn_req_2880_1800 balances_2880_1800

no, it dosen't work for me :(

ζˆͺ屏2021-07-15 09 12 39
sigurdarson commented 3 years ago

Any updates on the Safari development?

smeevil commented 3 years ago

πŸ‘€

bitweedx64 commented 3 years ago

I got one working here, build by yarn setup && yarn dist && yarn safari-extension-convert. Just merged from master branch today. You need to create .metamaskrc file with your INFURA_PROJECT_ID just like the content in .metamaskrc.dist. And a Xcode project will be generated in ./safari path. open the project and stage a Mac version. And there you go.

bitweedx64 commented 3 years ago

Oh I forgot the repository. It's here, branch safari.

winzig commented 3 years ago

Definitely won't be building this from some random fork... 😬

floam commented 3 years ago

Very wise. I can tell you are not amateur. You already know you should only connect via secure download. Blockchain e-verify is the most secure but how?

As not to over share details, send request kindly to var.log@icloud.com for special build. Under no circumstances may I request from you credential, I may only receive mnemonic word access code. Only send over wired connection and you will be contacted by a MetaMask representative for your Unique Secure Signed Enterprise level (USS Enterprise) install tooling. Hardware wallets are always safest this way. If you have a small amount of money, of course you might trust regular web shared web extension. Nothing to lose, nothing to due diligence for.

ghost commented 2 years ago

How's it going?

maxawad commented 2 years ago

It seems to be going stale @BurningPixels

xlab commented 2 years ago

It kinda works as a concept, but with 0 interest from Metamask's team it won't go any further.

haneenmahd commented 2 years ago

I mean I'm here to collaborate on building this for safari cause I hate chrome. Chrome actually is a ram sucker. it is such a piece of junk.

I can't just use another browser for just using metamask

danfinlay commented 2 years ago

with 0 interest from Metamask's team it won't go any further.

There is indeed interest from the MetaMask team! We're just balancing this against other priorities. I have no doubt that supporting Safari is a good idea, but we have quite a few other things on our plate. Please don't take non-immediate action as lack of interest.

winzig commented 2 years ago

Please don't take non-immediate action as lack of interest.

I think it’s just that the ticket was opened 17 months ago and there has been zero comment from MetaMask team since then, so people are assuming there’s no interest from the team based on that.

rivrwind commented 2 years ago

@danfinlay Seems like the base from @xlab could be used by the MetaMask team to get a start on a submission to the App store

lalabuy948 commented 2 years ago

Dear MetaMask, this is amazing piece of engineering. But what is stopping you from releasing official safari extension which was already prepared by @xlab from InjectiveLabs which works as a charm?

maxawad commented 2 years ago

It doesn't work right now does it?

I cloned the existing fork and it was not fully integrated

Max Awad CEO Co-Founder https://redxam.com

On Wed, Jan 12, 2022 at 10:28 AM Daniil Popov @.***> wrote:

Dear MetaMask, this is amazing piece of engineering. But what is stopping you from releasing official safari extension which was already prepared by @xlab https://github.com/xlab from InjectiveLabs which works as a charm?

β€” Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/8879#issuecomment-1010831046, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADATDQ7OG3JXZDH47FRDPY3UVVCSNANCNFSM4ONZCBXA . You are receiving this because you commented.Message ID: @.***>

melishev commented 2 years ago

So, are you planning to release an official version of MetaMask for Safari?

rkneipp commented 2 years ago

no, it dosen't work for me :( ζˆͺ屏2021-07-15 09 12 39

Same things here on M1 mac

haneenmahd commented 2 years ago

I need metamask safari extension as soon as possible because I do not prefer using Chrome because it is a RAM sucker and violates user privacy.

And have a lot of things to do in the meta verse and NFTs.

maxawad commented 2 years ago

Have you tried Brave, or the 1inch wallet?

This is still experimental

On Mon, Jan 17, 2022 at 5:32 PM Haneen Mahdin @.***> wrote:

I need metamask safari extension as soon as possible because I do not prefer using Chrome because it is a RAM sucker and violates user privacy.

And have a lot of things to do in the meta verse and NFTs.

β€” Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/8879#issuecomment-1014717970, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADATDQZP43U2WTF23PDSWA3UWRADDANCNFSM4ONZCBXA . You are receiving this because you commented.Message ID: @.***>

--

Max Awad CEO Co-Founder https://redxam.com

haneenmahd commented 2 years ago

Have you tried Brave, or the 1inch wallet? This is still experimental On Mon, Jan 17, 2022 at 5:32 PM Haneen Mahdin @.> wrote: I need metamask safari extension as soon as possible because I do not prefer using Chrome because it is a RAM sucker and violates user privacy. And have a lot of things to do in the meta verse and NFTs. β€” Reply to this email directly, view it on GitHub <#8879 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADATDQZP43U2WTF23PDSWA3UWRADDANCNFSM4ONZCBXA . You are receiving this because you commented.Message ID: @.> -- -- Max Awad CEO Co-Founder https://redxam.com

Might wanna try it out in safari because I do not want install another browser

garrytaulu commented 2 years ago

I need metamask safari extension as soon as possible because I do not prefer using Chrome because it is a RAM sucker and violates user privacy.

And have a lot of things to do in the meta verse and NFTs.

I’ve just started using Tokenary to sign into web 3 sites on Safari for Mac.

https://apps.apple.com/au/app/tokenary-ethereum-wallet/id1375542355

rkneipp commented 2 years ago

I’ve just started using Tokenary to sign into web 3 sites on Safari for Mac.

https://apps.apple.com/au/app/tokenary-ethereum-wallet/id1375542355

Great, it's work!

haneenmahd commented 2 years ago

I am a web3 developer, if I want to test and create Dapps, I might want to use chrome which I do not prefer for. Will use Tokenary until Metamask releases an officially supports Safari extension

maxawad commented 2 years ago

I'm going to check out Tokenary

Max Awad CEO Co-Founder https://redxam.com

On Wed, Jan 26, 2022 at 4:25 PM Haneen Mahdin @.***> wrote:

I am a web3 developer, if I want to test and create Dapps, I might want to use chrome which I do not prefer for. Will use Tokenary until Metamask releases an official version of Safari extension

β€” Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/8879#issuecomment-1022151056, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADATDQZ6Q3OPMZBUKSAXAXTUX7RZXANCNFSM4ONZCBXA . You are receiving this because you commented.Message ID: @.***>