Metadrop / scripthor

Swiss knife of scripts for speed up the development on drupal projects.
1 stars 10 forks source link

Remove sync label due is an optional parameter and not compatible with drush 11 #38

Closed Eduardo-Morales-Alberti closed 2 years ago

Eduardo-Morales-Alberti commented 2 years ago

On drush 11 the optional parameter label is removed, because we only use the sync directory (metadrop boilerplate), this label is not necessary for the previous versions.

drush 10.6.2:

Import config from a config directory.

Arguments:
 [label] A config directory label (i.e. a key in \$config_directories array in settings.php). 

Options:
 --preview[=PREVIEW] Deprecated. Format for displaying proposed changes. Recognized values: list, diff. [default: list]                                                                                                  
 --source=SOURCE     An arbitrary directory that holds the configuration files. An alternative to label argument                                                                                                         
 --partial           Allows for partial config imports from the source directory. Only updates and new configs will be processed with this flag (missing configs will not be deleted). No config transformation happens. 
 --diff              Show preview as a diff.                                                                                                                                                                             

Topics:
 drush topic docs:deploy Deploy command for Drupal.

drush 11.1.1:

wodby@php.container:/var/www/html $ drush cim --help
Import config from a config directory.

Options:
 --source=SOURCE An arbitrary directory that holds the configuration files.                                                                                                                                          
 --partial       Allows for partial config imports from the source directory. Only updates and new configs will be processed with this flag (missing configs will not be deleted). No config transformation happens. 
 --diff          Show preview as a diff. 
jorgetutor commented 2 years ago

It looks good to me

omarlopesino commented 2 years ago

Looks good to me too. I think that two approvals are enough to merge. There shouldn't be any issue with this MR as every project has always a default configuration name, so it won't break.