search

Metadrop / scripthor

Swiss knife of scripts for speed up the development on drupal projects.
1 stars 10 forks source link

update-helper.sh script does not work properly without author parameter #45

Closed albefer closed 1 year ago

albefer commented 1 year ago

When ./update-helper.sh is launched the updates and configuration are not commited, it only launch "git add". We need to save every change in modules in separate commits, and it is necessary to add the parameter author for this functionality to work.

Approach: Add a warning or error message when launching update-helper.sh without the author parameter, or launch an error message and prevent it from being executed.

omarlopesino commented 1 year ago

Between the two solutions proposed by albefer I'd prefer to display an error. The expected result of the script to generate a commit for each update/consolidation done. So the script must not start updating without that parameter

I propose , before doing anything in the script, checking that the author is not empty. In that case, display an error to the user.

omarlopesino commented 1 year ago

Deprecated issue because the command has been moved to metadrop/drupal-updater. Now the author has default value, so the problem is solved in drupal-updater.