Migrate to docker compose V2

Metadrop / scripthor

Swiss knife of scripts for speed up the development on drupal projects.

1 stars 10 forks source link

Migrate to docker compose V2 #56

Closed omarlopesino closed 6 months ago

omarlopesino commented 6 months ago

@rsanzante I've modified the file src/Handler.php to use docker compose V2 but I am not sure if that code is still used. The code does the boilerplate installation but as far as I know that is currently done by drupal boilerplate assistant, isn't it?

rsanzante commented 6 months ago

Right, the installation process is now done by the assistant. I guess I forgot to remove the code from Scripthor.

Anyway, I think it is ok to change it in this PR, no need to change the PR.

rsanzante commented 6 months ago

Mystery solved: the PR was against 2.x branch instead of 3.x, where assistant was removed. This is probably because I didn't mark 3.0.0 release as latest so you missed that branch when creating the PR.

I've cherry picked the fix into 4.x, because we consider this a breaking change (removed support for docker compose v1) and published a v4.0.0 release.