Meteor-Community-Packages / meteor-autocomplete

Client/server autocompletion designed for Meteor's collections and reactivity.
https://atmospherejs.com/mizzao/autocomplete
MIT License
350 stars 109 forks source link

meteor 0.9.1 fix #61

Closed illusionfield closed 10 years ago

mizzao commented 10 years ago

You probably want to test this before you send the pull request...

ianpogi5 commented 10 years ago

Not working for me.

Console error: Exception from Tracker recompute function: undefined is not a function TypeError: undefined is not a function at null._render

Stack trace was pointing to the code below return e=new AutoComplete(r.getCurrentData().settings)

mizzao commented 10 years ago

This PR was missing a bunch of things, but I think I've filled in the gaps and we're ready to release. Please give the master branch a test on 0.9.1.1.

illusionfield commented 10 years ago

I apologize in advance, I do not speak English... It was a little difficult to understand the latest post. I cloned latest master branch and tested 0.9.1.1.

Architecture: os.osx.x86_64 All tests pass!

mizzao commented 10 years ago

@illusionfield I meant an empirical test, as the unit tests don't cover much of actual usage.

I've released the latest as v0.4.8, as mentioned in #62. I'm pretty sure it works, but do try it out in your app.

illusionfield commented 10 years ago

Unfortunately I could not test "removed insecure" my projects will soon be ready to upgrade to 0.9.1.1, few days but the example "pubsublocal" works perfectly

~/work/test$ git clone --recursive git@github.com:mizzao/meteor-autocomplete.git mizzao:autocomplete
Cloning into 'mizzao:autocomplete'...
remote: Counting objects: 506, done.
remote: Compressing objects: 100% (25/25), done.
remote: Total 506 (delta 12), reused 1 (delta 0)
Receiving objects: 100% (506/506), 152.75 KiB | 77.00 KiB/s, done.
Resolving deltas: 100% (279/279), done.
Checking connectivity... done.   
~/work/test$ cd mizzao:autocomplete/examples/pubsublocal/
~/work/test/mizzao:autocomplete/examples/pubsublocal$ meteor update
Refreshing package metadata. This may take a moment.
This project is already at Meteor 0.9.1.1, the latest release.
~/work/test/mizzao:autocomplete/examples/pubsublocal$ meteor -p 4000
  downloading mizzao:bootstrap-3 at version 3.2.0 ...  done
  downloading mizzao:autocomplete at version 0.4.8 ...  done
[[[[[ ~/work/test/mizzao:autocomplete/examples/pubsublocal ]]]]]

=> Started proxy.
=> Started MongoDB.     
=> Started your app.   

=> App running at: http://localhost:4000/

[Log] Object (client.js, line 20)
_id: "0-0-0-1"
name: "ttts"
__proto__: Object

[Log] Object (client.js, line 20)
_id: "3-19-19-19"
name: "qaaa"
__proto__: Object

I hope I understand it and I managed to do what you asked, if not please Explain in more detail. English is not my native language ...

mizzao commented 10 years ago

What do you mean you cannot test "removed insecure"?

illusionfield commented 10 years ago

i thinking: insecure meteor package my apps do not include insecure package i just wanted to write that I could not even be tested in this way

actually, it's just little things sorry for the misunderstanding

mizzao commented 10 years ago

I really don't understand - this package should work with our without insecure, either way.