search

Meteor-Community-Packages / meteor-autocomplete

Client/server autocompletion designed for Meteor's collections and reactivity.
https://atmospherejs.com/mizzao/autocomplete
MIT License
350 stars 109 forks source link

Meteor 0.9.1 breaks autocomplete templates #62

Closed sferoze closed 10 years ago

sferoze commented 10 years ago

Hello,

I just updated to meteor 0.9.1 and when I tried running the app, the autocomplete template could not be found and broke my whole app. So currently I am using 0.9.0 and it works fine. Is anyone else having this issue?

mizzao commented 10 years ago

Yep, looks like #61...give that PR a try and see if it works?

sferoze commented 10 years ago

Hi, I am sorry but how to I try a specific push release if it is not on atmosphere? Currently I installed autocomplete by using 'meteor add mizzao:autocomplete' I am willing to try if you let me know

mizzao commented 10 years ago

You will need to git clone that fork into packages/mizzao:autocomplete to use it in your app. For that repo:

git clone https://github.com/illusionfield/meteor-autocomplete packages/mizzao:autocomplete
sferoze commented 10 years ago

So I need to first remove the current autocomplete. Then run

git clone https://github.com/illusionfield/meteor-autocomplete packages/mizzao:autocomplete

while in the root folder of my app? And then I should have the new version to test?

Then if it works, do I just delete the cloned folder, and add the package from atmosphere?

mizzao commented 10 years ago

Yes. (Add back the package from atmosphere after I've released a new version.)

sferoze commented 10 years ago

Hmm I cloned the package into the package directory and removed the meteor atmosphere package. But now it is not even recognizing the inputAutocomplete template. I think cloning the package into the packages folder did not work to make Meteor recognize the package....

myapp packages mizzao/autocomplete

that is where the package is but it is not working as in not even recognized

sferoze commented 10 years ago

Can anyone else test it out?

ianpogi5 commented 10 years ago

Not working for me @mizzao

See #61 for the error

mizzao commented 10 years ago

@ianpogi5 I think things are happy now. Would you give the master branch a try, so that I can release a new version of the package if all is well?

bruz commented 10 years ago

I just ran into this too, and can confirm it's working for me with what's on master now.

ianpogi5 commented 10 years ago

master branch working on my end too. Thanks!

mizzao commented 10 years ago

@bruz I think you committed 8ffaa56a3b03d9f3a8dd117dfabc34c2df844091 while I was doing ba588941c309ea809f9ee9833648d1b346a0d8d6, and I saw that you deleted it after my commit went in. I actually looked over yours to check if I had missed anything - it was helpful, as I actually amended my commit - so you didn't waste any effort!

Two votes is good enough for me! Just released v0.4.8.

bruz commented 10 years ago

Thanks @mizzao. I hadn't dug around in Meteor's internals much before so it was educational to start exploring that, and then see the final set of changes you committed for the fix.