search

Metro-Records / la-metro-councilmatic

:metro: An instance of councilmatic for LA Metro
MIT License
6 stars 2 forks source link

Show today's meetings on the homepage on meeting days #694

Closed hancush closed 3 years ago

hancush commented 3 years ago

In place of the About section to the right of the upcoming / current meeting block, show the day's meetings and their status (passed, live, scheduled or something to that effect).

hancush commented 3 years ago

Part 1: Show the About section or a new "Today's Meetings" section in its place on the homepage, conditional on whether there are any meetings scheduled today.

Part 2: Render the day's meetings with the correct status. Leverage existing code to determine whether a meeting is passed, ongoing, or scheduled.

@fatima3558 How about you submit a draft PR for review after you finish Part 1?

fgomez828 commented 3 years ago

@hancush was able to get part 1 done without too much trouble. Here's the first part of the PR: https://github.com/datamade/la-metro-councilmatic/pull/698

fgomez828 commented 3 years ago

@shrayshray The changes for this issue are now on the staging site! It looks like the soonest there will be meetings is Thursday, May 27. Could you give the staging site a look sometime then and let us know what you think?

shrayshray commented 3 years ago

@fatima3558 Wow, this looks great!! image

fgomez828 commented 3 years ago

@shrayshray great! are there any tweaks we should make before deploying to the live site?

shrayshray commented 3 years ago

@fatima3558 no tweaks at the moment, though I do want to keep an eye on how it displays on days with multiple meetings. I'm comfortable with going live though - thanks, Fatima!

shrayshray commented 3 years ago

@fatima3558 i noticed on little issue with display - the "upcoming" buble on the first meeting looks like it's cut-off on the line break: image

hancush commented 3 years ago

@shrayshray Ah! What browser are you using?

shrayshray commented 3 years ago

@hancush Firefox. I just checked and it's happening on "Concluded", too - but it looks great in Chrome!

hancush commented 3 years ago

Thanks, @shrayshray! I just put a patch in and forced meetings to display to test in Firefox. See https://github.com/datamade/la-metro-councilmatic/pull/729#issue-660962057.

Ok to go ahead and deploy?

shrayshray commented 3 years ago

@hancush yes, ready to deploy!

hancush commented 3 years ago

It's live, @shrayshray!