Metro-Records / la-metro-councilmatic

:metro: An instance of councilmatic for LA Metro
MIT License
6 stars 2 forks source link

Meetings can be incorrectly reported as concluded when the previous meeting runs over #772

Closed hancush closed 2 years ago

hancush commented 2 years ago

Our logic to check whether a meeting has concluded assumes that if it's after a meeting's start time, but the meeting is not live, then that meeting has concluded. This isn't necessarily the case, as meetings can start late if a prior meeting runs over, or for some other reason.

If a previous meeting (or concurrently scheduled) meeting is still streaming, the meeting has not yet started and should not be marked as concluded.

It's a bit harder if there is not a previous meeting. For current meetings, we introduced a 20-minute buffer to account for late starts. @shrayshray, does a similar approach make sense here? What's a reasonable buffer for the start time of the first meeting of the day?

hancush commented 2 years ago

@shrayshray Is it true that every meeting will be broadcast?

If so, we could simplify the logic to determine whether a meeting is over by marking a meeting as having been streamed when it is returned by the running events endpoint (http://metro.granicus.com/running_events.php). (We use this endpoint to determine when meetings are current.) Then, we can use that indicator to tell when the meeting has concluded. The logic would look like:

If the meeting has been streamed but is no longer ongoing, then it's concluded. Otherwise, it is not concluded.

What do you think?

hancush commented 2 years ago

@shrayshray Let me know if you have thoughts on https://github.com/datamade/la-metro-councilmatic/issues/772#issuecomment-1016560742!

shrayshray commented 2 years ago

@hancush Yes, every meeting will be broadcast. This sounds effective to me: "If the meeting has been streamed but is no longer ongoing, then it's concluded. Otherwise, it is not concluded."

camachoo commented 2 years ago

Reference screenshot for meetings occurring on 1/27/2022. Regular Board meeting had not started yet, but the LA Safe meeting was running.

Omar Camacho Sr. Manager, Systems Projects, Research & Records Information Management Office of Board Administration 213.922.2335

Metro Los Angeles metro.net | facebook.com/losangelesmetro | @metrolosangeles Metro provides excellence in service and support.

From: shrayshray @.> Sent: Thursday, January 27, 2022 1:44 PM To: datamade/la-metro-councilmatic @.> Cc: Subscribed @.***> Subject: Re: [datamade/la-metro-councilmatic] Meetings can be incorrectly reported as concluded when the previous meeting runs over (Issue #772)

@hancushhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhancush&data=04%7C01%7Ccamachoo%40metro.net%7C2ff211e02e71485f1dd908d9e1de12f7%7Cab57129bdbfd4cacaa77fc74c40364af%7C1%7C0%7C637789166179722066%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=bfZJFRxjyppd9iK1eUA8%2BNWrEkvCm62qRfhP%2FI0S0m8%3D&reserved=0 Yes, every meeting will be broadcast. This sounds effective to me: "If the meeting has been streamed but is no longer ongoing, then it's concluded. Otherwise, it is not concluded."

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdatamade%2Fla-metro-councilmatic%2Fissues%2F772%23issuecomment-1023665289&data=04%7C01%7Ccamachoo%40metro.net%7C2ff211e02e71485f1dd908d9e1de12f7%7Cab57129bdbfd4cacaa77fc74c40364af%7C1%7C0%7C637789166179722066%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=82Cvc51sTb3Xkw7zGYmUSh1vSUR8S8v6LPDwCAgcxq8%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAG3PL6U4TFJ2TADQ35IKXTDUYG4ARANCNFSM5IKSDVZA&data=04%7C01%7Ccamachoo%40metro.net%7C2ff211e02e71485f1dd908d9e1de12f7%7Cab57129bdbfd4cacaa77fc74c40364af%7C1%7C0%7C637789166179722066%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nRKAe%2Bx87njd4kXjh0BJN1T1hmu3N5XVDrYBUllPbH8%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Ccamachoo%40metro.net%7C2ff211e02e71485f1dd908d9e1de12f7%7Cab57129bdbfd4cacaa77fc74c40364af%7C1%7C0%7C637789166179722066%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=h9hrR6GcwOh42ZV60226LcTpm8Vd1LevnUIO03PJBDg%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Ccamachoo%40metro.net%7C2ff211e02e71485f1dd908d9e1de12f7%7Cab57129bdbfd4cacaa77fc74c40364af%7C1%7C0%7C637789166179722066%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=rpSBo9LSSfTF55dHCzp9UbZ7gjy%2FLi%2B4D0OBp%2FkoS1Y%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

hancush commented 2 years ago

I will draft this ahead of February meetings and we'll trial it on staging!

hancush commented 2 years ago

@shrayshray I've deployed the change in logic to the staging site: https://lametro-upgrade.datamade.us/

Can you keep an eye on it during this week's meetings and let me know whether you spot anything amiss?

hancush commented 2 years ago

FYI @shrayshray @camachoo this is redeployed to staging for testing during today's meeting: https://lametro-upgrade.datamade.us/

shrayshray commented 2 years ago

Apologies, I was caught up in other troubleshooting during last week's meetings. I set up a calendar reminder to watch the site during next month's meetings and will report back.

hancush commented 2 years ago

No problem, @shrayshray, sounds like a plan! 👍

hancush commented 2 years ago

This, along with #790, has been staged ahead of tomorrow's meetings, @shrayshray!

shrayshray commented 2 years ago

@hancush Today's meeting didn't run over, but it was showing as "In Progress" and "Concluded" as expected! Will keep an eye out tomorrow as well.

hancush commented 2 years ago

Deployed.