Closed hancush closed 3 weeks ago
I did some snooping with browserstack and my phone to see how things are. Here are some thoughts on some pages. Lmk what you think @hancush, I can pick any or all of these up anytime:
General
Homepage:
Board members listing:
About Us
Board report search
Events listing
Minutes search:
Event detail:
@xmedr Thanks for this! Let's start working through these by section. Want to pick up the General and Homepage items?
Let's also take this opportunity to upgrade to the latest Bootstrap! As there are quite a few changes between legacy and contemporary Bootstrap, I'd like you to reproduce the existing site design but write the new templates from scratch (of course, copying and pasting content and other reusable elements). LMK if this makes sense!
Can you open up a branch called "mobile-updates", then branch off that branch and start your changes? We'll use "mobile-updates" as a long-lived feature dev branch and continue to branch off of it as we move through this list.
@hancush Yep this sounds good to me, and in that case I'll probably do the bootstrap upgrade in tandem with the mobile updates. Ty!
@hancush update for you, I was able to get a draft of the General and Homepage upgrades and bootstrap migration on the mobile-adjustments
branch, and I've started work on the About Us (was hoping I could knock that out before EOD today, but I'm almost done with that one)
@shrayshray These changes are deployed to the staging site! https://lametro.datamade.us/ Want to take a spin and let us know what you think?
@xmedr to redeploy to staging for Metro review in October.
@shrayshray These changes are redeployed at https://lametro.datamade.us/ and includes the most recent updates at time of writing. That includes things like the alert manager and the Caltrans board members map layer.
Note: The alert manager uses styles based on this upgrade. So on the live site, the Primary and Secondary alerts may not have specific colors until this is brought in. The other alerts should work just fine for now, though.
@xmedr This is looking great to me on my iOS devices, and I have a couple notes below. I asked @camachoo and @neilarellano to check on their devices and add feedback here as well. Notes:
On meeting pages, it looks like there could be some vertical space added between the recording buttons:
Can you add a scroll bar to the list of directors on the mobile version, similar to on the desktop version (screenshot below)? This would make it more clear there are more directors in the list to view.
Can the view PDF and download buttons be emphasized, either with bold or larger font on the Board Report pages?
Is it possible to reissue admin login credentials to the staging site? The credentials I have aren't working to login and see the new alert styles. This is only if you want me to review the new alert styles here, before they are live (but not a huge deal because we'd preview them on live before pushing to users anyway).
@shrayshray Thanks for this! To answer your questions:
@xmedr Can you provide an update on this?
@shrayshray I've got an email coming your way with new login credentials for the staging site at https://lametro.datamade.us/ , and changes from your feedback has been redeployed there.
There's also some bonus changes from the first round of accessibility adjustments discussed in #1021. The most notable changes are higher color contrast throughout the site, and the addition of underlines to links to help distinguish them beyond just color.
If you have the time, would you be able to take a look at this by the end of the week? No worries if you folks are busy!
@xmedr on the homepage, could you add additional contrast to the text below the search box? Maybe a white background behind it? The image behind the text obscures it in some views and while the new higher contrast helps, more would be better.
@shrayshray of course! though it looks like you might be looking at a different version of the site. is this maybe the link for the staging site on heroku that was recently shared with you? if so, that unfortunately doesn't have the styling changes on there. sorry for not realizing this would've been confusing sooner!
we'll be keeping the old staging site available until these changes are approved. so for now that's going to be at https://lametro.datamade.us/ and if anything else changes i'll be sure to give an update. so on this link, that text looks something more like:
and i can definitely still increase the contrast more if we need
@xmedr my screenshot was from the live site and it definitely looks better on staging than on live! But Omar requested even more contrast than what we're seeing on staging.
@shrayshray absolutely! here's what it looks like in that white box. and i agree, this does feel way more readable.
also change of plans on that old staging site. we did end up taking that down, and instead we're putting these changes up on the new heroku staging site you were using before, found at https://la-metro-councilmatic-staging.herokuapp.com/. apologies for that bout of switching and thanks for bearing with me on this! 🙇
@xmedr beautiful! Thank you!
@shrayshray absolutely! and of course let me know if you folks find anything else on this or if we're good to go
@neilarellano @camachoo these changes are back on staging for review!
Hi Team,
I noticed when I was going through Board Reports search results that some informational labels were overlapping on Android mobile. Please see below:
@neilarellano thanks for catching that! i've got that fixed, and staging now looks like below. let me know whether you find anything else
@shrayshray Thanks again for signing off on the current set of mobile/accessibility changes! The next two parts are up on the staging site now for you folks to review. Here are some major things to look out for, for each category:
In the meantime, we'll continue work on the last category.
@shrayshray we're close to done with the 4th leg of the a11y changes! though we'll still hold off on bringing it in to the staging site until this previous round of review is done.
Updating this with details from the latest meeting. We’re done with the last category of the a11y changes and just waiting for the previous two to get tested so we can push this last one up. Once that's finished, we can get everything onto the main site!
@shrayshray were you folks able to find any issues with the "operable" and "understandable" categories? If not, I can push the last bit up
@camachoo @neilarellano As mentioned in today's meeting, below is the link to the review app containing the Operable and Understandable changes (instructions for testing listed above), as well as the Robust changes. This environment will be a bit outdated as far as other changes that have been made throughout the site, but will be sufficient to test these particular accessibility adjustments!
Review app - https://la-metro-cou-a11y-robus-n1od02.herokuapp.com/
Hi Team! We have confirmed most of the listed updates. Below is a list of comments and questions we have for the line items below:
Thanks so much for this @neilarellano! I've got an updated version of these changes merged in with the latest changes to the site at: https://la-metro-cou-a11y-robus-rcwgkd.herokuapp.com/
Here's some answers to your comments. If this looks good then we can treat this as a checkpoint to get things merged in and continue work from here!
aria-label
. Here's an example of a search result in chrome, with the gray box being a visual representation of what VoiceOver reads:
@neilarellano Whenever you get a chance, let me know how this looks to you!
hi @xmedr
The alert can now be tabbed through but it is not being read by the screen reader. I do see the aria-label for links that open in new tabs, however, I am still unable to have the "link opens in new tab" be read aloud. I used Edge's default reader and tried it on Chrome on 2 different screen reader extensions. The rest looks good.
@neilarellano Got it! I'll do some more testing with Edge and Chrome. Which screen reader extensions are you using on Chrome?
@neilarellano Is the Edge default reader you're using the Read Aloud feature? If not, then I can use whichever one you're using instead. But if so:
Also for Chrome, I tested using Screen Reader and Screen Reader with On-Off Button and both were able to read the alert and the "link opens in a new tab" portion of the aria-label (though "Screen Reader with On-Off Button" was a bit unwieldy to use). I can definitely still try whichever specific extensions you've tried though to see what's going on with them.
Do we have a full list of accessibility and mobile changes that have been made and not made? I think there was a full checklist, right @xmedr?
@camachoo Apologies for the delay. Yes, each of the a11y issues is a checklist of items to consider, and each of their attached PRs has a Notes section with specific details on some changes. Here's a list of each issue and its corresponding PR:
Perceivable:
Operable:
Understandable:
Robust:
@neilarellano Let me know if you have any updates/questions on your testing! It would be great if we could bring this in soon.
@xmedr I was able to test the TTS options and was able to get the same results. It is a shame that Edge's native reader doesn't support aria-label. It did work fine for me when testing through other TTS extensions in Edge and Chrome.
As for the alerts, should these alerts be read first before the site's main content? I think that would be useful in scenarios where we experience technical issues but have important announcements/workarounds through the alerts. Would it be possible to do this? Would there be issues or disadvantages to having the alerts always be selected/read first?
In order to get this issue and its related prs closed and merged, I've opened issue #1172 for this last Edge bug.
Closed by the final a11y category pr #1088 and now pushing these changes to production after successfully testing on staging.
Thanks for all the help on this, team!
About 10% of our users visit the site on a mobile or tablet device. That might not sound like much, but it amounts to ~7,000 people this year. The quality of site display on smaller screens is pretty variable. Let's put some thought into improving display for non-desktop devices.