Metro-Records / la-metro-councilmatic

:metro: An instance of councilmatic for LA Metro
MIT License
6 stars 2 forks source link

Improve mobile display #969

Closed hancush closed 3 weeks ago

hancush commented 1 year ago

About 10% of our users visit the site on a mobile or tablet device. That might not sound like much, but it amounts to ~7,000 people this year. The quality of site display on smaller screens is pretty variable. Let's put some thought into improving display for non-desktop devices.

xmedr commented 1 year ago

I did some snooping with browserstack and my phone to see how things are. Here are some thoughts on some pages. Lmk what you think @hancush, I can pick any or all of these up anytime:

hancush commented 1 year ago

@xmedr Thanks for this! Let's start working through these by section. Want to pick up the General and Homepage items?

Let's also take this opportunity to upgrade to the latest Bootstrap! As there are quite a few changes between legacy and contemporary Bootstrap, I'd like you to reproduce the existing site design but write the new templates from scratch (of course, copying and pasting content and other reusable elements). LMK if this makes sense!

Can you open up a branch called "mobile-updates", then branch off that branch and start your changes? We'll use "mobile-updates" as a long-lived feature dev branch and continue to branch off of it as we move through this list.

xmedr commented 1 year ago

@hancush Yep this sounds good to me, and in that case I'll probably do the bootstrap upgrade in tandem with the mobile updates. Ty!

xmedr commented 1 year ago

@hancush update for you, I was able to get a draft of the General and Homepage upgrades and bootstrap migration on the mobile-adjustments branch, and I've started work on the About Us (was hoping I could knock that out before EOD today, but I'm almost done with that one)

hancush commented 1 year ago

@shrayshray These changes are deployed to the staging site! https://lametro.datamade.us/ Want to take a spin and let us know what you think?

hancush commented 1 year ago

@xmedr to redeploy to staging for Metro review in October.

xmedr commented 1 year ago

@shrayshray These changes are redeployed at https://lametro.datamade.us/ and includes the most recent updates at time of writing. That includes things like the alert manager and the Caltrans board members map layer.

Note: The alert manager uses styles based on this upgrade. So on the live site, the Primary and Secondary alerts may not have specific colors until this is brought in. The other alerts should work just fine for now, though.

shrayshray commented 1 year ago

@xmedr This is looking great to me on my iOS devices, and I have a couple notes below. I asked @camachoo and @neilarellano to check on their devices and add feedback here as well. Notes:

  1. On meeting pages, it looks like there could be some vertical space added between the recording buttons: 91E4A3D5-F58E-474E-913E-FEE0423670E2

  2. Can you add a scroll bar to the list of directors on the mobile version, similar to on the desktop version (screenshot below)? This would make it more clear there are more directors in the list to view. image

  3. Can the view PDF and download buttons be emphasized, either with bold or larger font on the Board Report pages? 8C3CF8D4-40CD-4968-92D1-5C94BCB48405

  4. Is it possible to reissue admin login credentials to the staging site? The credentials I have aren't working to login and see the new alert styles. This is only if you want me to review the new alert styles here, before they are live (but not a huge deal because we'd preview them on live before pushing to users anyway).

xmedr commented 1 year ago

@shrayshray Thanks for this! To answer your questions:

  1. Good catch, there absolutely can be some space in between those buttons
  2. So far, the appearance of the scroll bar seems like it's controlled by the mobile OS. I'll do some more digging on this though to be sure. In case it doesn't pan out, the plus side is that it does show once you start scrolling.
  3. For sure, we can get that emphasized. Below I have an example of both a font size increase and bolded text, what do you think? If it's too much we can just do one or the other.
  4. That'd be useful to for you all to have working logins for the future even, so we'll get that back up
image
hancush commented 1 year ago

@xmedr Can you provide an update on this?

xmedr commented 1 year ago

@shrayshray I've got an email coming your way with new login credentials for the staging site at https://lametro.datamade.us/ , and changes from your feedback has been redeployed there.

There's also some bonus changes from the first round of accessibility adjustments discussed in #1021. The most notable changes are higher color contrast throughout the site, and the addition of underlines to links to help distinguish them beyond just color.

If you have the time, would you be able to take a look at this by the end of the week? No worries if you folks are busy!

shrayshray commented 12 months ago

@xmedr on the homepage, could you add additional contrast to the text below the search box? Maybe a white background behind it? The image behind the text obscures it in some views and while the new higher contrast helps, more would be better. image

xmedr commented 12 months ago

@shrayshray of course! though it looks like you might be looking at a different version of the site. is this maybe the link for the staging site on heroku that was recently shared with you? if so, that unfortunately doesn't have the styling changes on there. sorry for not realizing this would've been confusing sooner!

we'll be keeping the old staging site available until these changes are approved. so for now that's going to be at https://lametro.datamade.us/ and if anything else changes i'll be sure to give an update. so on this link, that text looks something more like:

image

and i can definitely still increase the contrast more if we need

shrayshray commented 11 months ago

@xmedr my screenshot was from the live site and it definitely looks better on staging than on live! But Omar requested even more contrast than what we're seeing on staging.

xmedr commented 11 months ago

@shrayshray absolutely! here's what it looks like in that white box. and i agree, this does feel way more readable.

also change of plans on that old staging site. we did end up taking that down, and instead we're putting these changes up on the new heroku staging site you were using before, found at https://la-metro-councilmatic-staging.herokuapp.com/. apologies for that bout of switching and thanks for bearing with me on this! 🙇

image

shrayshray commented 11 months ago

@xmedr beautiful! Thank you!

xmedr commented 11 months ago

@shrayshray absolutely! and of course let me know if you folks find anything else on this or if we're good to go

xmedr commented 10 months ago

@neilarellano @camachoo these changes are back on staging for review!

https://la-metro-councilmatic-staging.herokuapp.com/

neilarellano commented 10 months ago

Hi Team,

I noticed when I was going through Board Reports search results that some informational labels were overlapping on Android mobile. Please see below:

image

xmedr commented 10 months ago

@neilarellano thanks for catching that! i've got that fixed, and staging now looks like below. let me know whether you find anything else

image

xmedr commented 9 months ago

@shrayshray Thanks again for signing off on the current set of mobile/accessibility changes! The next two parts are up on the staging site now for you folks to review. Here are some major things to look out for, for each category:

Operable (2 of 4)

Understandable (3 of 4)

In the meantime, we'll continue work on the last category.

xmedr commented 9 months ago

@shrayshray we're close to done with the 4th leg of the a11y changes! though we'll still hold off on bringing it in to the staging site until this previous round of review is done.

xmedr commented 8 months ago

Updating this with details from the latest meeting. We’re done with the last category of the a11y changes and just waiting for the previous two to get tested so we can push this last one up. Once that's finished, we can get everything onto the main site!

@shrayshray were you folks able to find any issues with the "operable" and "understandable" categories? If not, I can push the last bit up

xmedr commented 3 months ago

@camachoo @neilarellano As mentioned in today's meeting, below is the link to the review app containing the Operable and Understandable changes (instructions for testing listed above), as well as the Robust changes. This environment will be a bit outdated as far as other changes that have been made throughout the site, but will be sufficient to test these particular accessibility adjustments!

Review app - https://la-metro-cou-a11y-robus-n1od02.herokuapp.com/

Robust testing instructions (4 of 4)

neilarellano commented 3 months ago

Hi Team! We have confirmed most of the listed updates. Below is a list of comments and questions we have for the line items below:

  1. About us page’s Board Report Status table section – it may not be clear that this is a table being read aloud. The headings are read but the content of the table may not be understandable.
  2. Pages containing board report numbers have the dashes read as “to” instead of a dash. For example 2024-0001 is read as “two zero two four to zero zero zero one” instead of “two zero two four dash zero zero zero one”. I am unsure if this is something we can do anything about or if this is dependent on the specific reader used.
  3. The agenda PDF is not being read aloud even though the PDF can be tabbed through. I’m not sure if this is expected behavior.
  4. The alert banner that we set is not being read aloud at all in any page where it is visible.
xmedr commented 3 months ago

Thanks so much for this @neilarellano! I've got an updated version of these changes merged in with the latest changes to the site at: https://la-metro-cou-a11y-robus-rcwgkd.herokuapp.com/

Here's some answers to your comments. If this looks good then we can treat this as a checkpoint to get things merged in and continue work from here!

xmedr commented 2 months ago

@neilarellano Whenever you get a chance, let me know how this looks to you!

neilarellano commented 2 months ago

hi @xmedr

The alert can now be tabbed through but it is not being read by the screen reader. I do see the aria-label for links that open in new tabs, however, I am still unable to have the "link opens in new tab" be read aloud. I used Edge's default reader and tried it on Chrome on 2 different screen reader extensions. The rest looks good.

xmedr commented 2 months ago

@neilarellano Got it! I'll do some more testing with Edge and Chrome. Which screen reader extensions are you using on Chrome?

xmedr commented 2 months ago

@neilarellano Is the Edge default reader you're using the Read Aloud feature? If not, then I can use whichever one you're using instead. But if so:

Also for Chrome, I tested using Screen Reader and Screen Reader with On-Off Button and both were able to read the alert and the "link opens in a new tab" portion of the aria-label (though "Screen Reader with On-Off Button" was a bit unwieldy to use). I can definitely still try whichever specific extensions you've tried though to see what's going on with them.

camachoo commented 1 month ago

Do we have a full list of accessibility and mobile changes that have been made and not made? I think there was a full checklist, right @xmedr?

xmedr commented 1 month ago

@camachoo Apologies for the delay. Yes, each of the a11y issues is a checklist of items to consider, and each of their attached PRs has a Notes section with specific details on some changes. Here's a list of each issue and its corresponding PR:

Perceivable:

Operable:

Understandable:

Robust:

xmedr commented 1 month ago

@neilarellano Let me know if you have any updates/questions on your testing! It would be great if we could bring this in soon.

neilarellano commented 4 weeks ago

@xmedr I was able to test the TTS options and was able to get the same results. It is a shame that Edge's native reader doesn't support aria-label. It did work fine for me when testing through other TTS extensions in Edge and Chrome.

As for the alerts, should these alerts be read first before the site's main content? I think that would be useful in scenarios where we experience technical issues but have important announcements/workarounds through the alerts. Would it be possible to do this? Would there be issues or disadvantages to having the alerts always be selected/read first?

xmedr commented 3 weeks ago

In order to get this issue and its related prs closed and merged, I've opened issue #1172 for this last Edge bug.

xmedr commented 3 weeks ago

Closed by the final a11y category pr #1088 and now pushing these changes to production after successfully testing on staging.

Thanks for all the help on this, team!