search

MetroStar / conda-vendor

Conda package for artifact creation that enables offline environments. Ideal for air-gapped deployments.
MIT License
14 stars 8 forks source link

Use pathlib in conda_vendor.py, fix issue 38 #39

Closed iameskild closed 2 years ago

iameskild commented 2 years ago

Fixes #38

I believe this fixes the issue that was causing trouble last week. While working through the fix, I took's @kcpevey suggestion and converted path-like objects from str to pathlib.Path objects. This did also require swapping out the tmpdir fixture for tmp_path_factory, the latter of which returns a pathlib.Path object.

iameskild commented 2 years ago

Thanks for the review @kcpevey! I believe I've made all of the suggested changes :)