search

MiSTer-devel / Amstrad_MiSTer

Amstrad CPC 6128 for MiSTer
26 stars 15 forks source link

Sync mi st #23

Closed littlelazyexperiment closed 1 year ago

littlelazyexperiment commented 1 year ago

Hello Sorgelig,

I have updated the Core with the last changes coming from MiST. All the changes are straight forward: this is also why I could do them. The last ones related to the implementation of Symbiface II support for IDE are beyond my catch at the moment, so they are not included. If you could have a look, this would be great. Anyway, I hope this helps you maintain the Amstrad Core a little bit.

Cheers and thank you for all the inspiring work!

sorgelig commented 1 year ago

Did you check all those tricky demos manipulating CRTC?

littlelazyexperiment commented 1 year ago

No, I did not. The CRTC implementation looked identical to me between MiST and MiSTer. I assumed that if these changes had been successfully tested with the MiST, it wouldn’t hurt aligning the implementation back together. If you want, I can generate a test build and let the community check if it is working as intended before you consider the changes?

Alexey Melnikov @.***> schrieb am So. 23. Juli 2023 um 20:32:

Did you check all those tricky demos manipulating CRTC?

— Reply to this email directly, view it on GitHub https://github.com/MiSTer-devel/Amstrad_MiSTer/pull/23#issuecomment-1646925259, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZ6R6GETFUGSF7P4DNIJRTXRVUZ7ANCNFSM6AAAAAA2UMGKFM . You are receiving this because you authored the thread.Message ID: @.***>

sorgelig commented 1 year ago

It's ok to update, but CRTC is very sensitive part of Amstrad. Long time ago when i was working hard on Amstrad core it was pretty hard to tune CRTC to please all those tricky demos. And if you miss something then it won't work while it looks like the same as on MiST. So it's better to check if nothing broken and you didn't miss something.

littlelazyexperiment commented 1 year ago

I understand completely. I have generated a test build and posted a request for testing on the discord channel in the computer core thread. Let see if anyone is interested :-)

Breiztiger commented 1 year ago

Tested some demo ok Just i think alt-f11 no necessary

wwark commented 1 year ago

I have tested also demos all seems to work great with verifying some with YT video if existed !