search

MiSTer-devel / Amstrad_MiSTer

Amstrad CPC 6128 for MiSTer
24 stars 15 forks source link

Missing sound on JET BOOT JACK #4

Closed Titofff closed 4 years ago

Titofff commented 4 years ago

Hello !

Same problem as boulderdash missing sound when jack move.

gyurco commented 4 years ago

Maybe this one: https://github.com/gyurco/MiSTery/commit/e5556cc2cb4e8f37d18dda0f1386fdc5561a4118 Helped on Atari ST with some missing sounds (tone_gen_op[i] <= ~ymreg[7][i]; is the relevant part)

sorgelig commented 4 years ago

@gyurco thanks! i will check that. I think using BRAM for simple volume mixing is too exaggerated ;)

sorgelig commented 4 years ago

Yep, that line fixes the sound.

gyurco commented 4 years ago

The problem is that the "mixing" on Atari ST is just short-circuiting the three output channels, and the output is not a linear function of the 3 values. For playing back PCM sound (very common on the ST), it's mandatory to simulate the original output, otherwise the result is too noisy and/or distorted.

gyurco commented 4 years ago

Btw, I've did some improvements in the MiST version: https://github.com/gyurco/Amstrad_MiST/commits/master Then I discovered that the GA already decapped & reverse engineered, so probably I'll work on it a bit more.

sorgelig commented 4 years ago

CRTC improvements would be more beneficial.

gyurco commented 4 years ago
Titofff commented 4 years ago

Fixed with last release "Amstrad_20200131".

Thanks a lot ! sounds ok now for Boulder Dash & Jet Boot Jack et some others probably.