search

MiSTer-devel / ZX-Spectrum_MISTer

43 stars 32 forks source link

Wrong colors. #34

Closed FranciscoJavierDiazBlanco closed 2 years ago

FranciscoJavierDiazBlanco commented 2 years ago

The dark tones of the colors are too dark.
Core zx spectrum photo: https://ibb.co/TR2wFvN Core ZXNext Photo: https://ibb.co/WDyBPth

jonpatterson commented 2 years ago

I can confirm I have the same issue. I've attached two images of the colour test screen, one captured from the ZX Spectrum core and the other from the ZX Spectrum Next core. From what I can see it looks like the bright half of the palette is pretty similar, but the basic half is too dark. The ZX Spectrum Next core seems to accurately represent the colours as I'd expect.

ZX Spectrum zx_spectrum ZX Spectrum Next zx_spectrum_next

sorgelig commented 2 years ago

try this build: ZX-Spectrum.zip

jonpatterson commented 2 years ago

try this build: ZX-Spectrum.zip

A massive improvement! The same colour test screen on the ZX Spectrum and ZX Spectrum Next cores are very similar now.

I took two screenshots from the cores again and compared the hex values. For the basic colours they are identical, with the exception of magenta which is slightly different. Comparing the bright values, if anything the ZX Spectrum core looks a little brighter than the ZX Next core now! Interestingly I also took a screenshot of the same test screen in the Fuse emulator and it's identical to the ZX Spectrum build you provided.

Many thanks Alexey, this looks good to me 👍

ZX Spectrum Next zx_next_test

ZX Spectrum zx_spectrum_test

Fuse Emulator fuse_test

FranciscoJavierDiazBlanco commented 2 years ago

try this build: ZX-Spectrum.zip

Perfect, in this core the colors look good. Thank you.

Alvarez81 commented 2 years ago

@FranciscoJavierDiazBlanco ...well, so close this issue, please.