search

MickaelRigault / skysurvey

Simulate transients within the sky
Apache License 2.0
9 stars 7 forks source link

Akshay panayada rkilonova #19

Closed AkshayPanayada closed 1 year ago

AkshayPanayada commented 1 year ago

I made some changes to kilonova file. Made a data directory. Changed the fle path in the python file

MickaelRigault commented 1 year ago

Hi @AkshayPanayada, I'll review that, it looks clean enough. is this MR supposed to replace the work in #16

MickaelRigault commented 1 year ago

Furthermore, data should not be inside "skysurvey/target". I have to admit, I'm not a huge fan of data inside a package (apart say filter bandpass etc). I would rather have that stored somewhere else and downloaded up on request (like "dustmaps" for instance).

I'll think about a way