search

MickaelRigault / skysurvey

Simulate transients within the sky
Apache License 2.0
9 stars 7 forks source link

Akshay panayada rkilonova #22

Closed AkshayPanayada closed 9 months ago

AkshayPanayada commented 9 months ago

There was no ra and dec incorporated in the kilonova module. This resulted in error while doing the survey. Modified it accordingly. However, I dont know how to modify the theta values. Will modify after understanding it.

MickaelRigault commented 9 months ago

@AkshayPanayada

I implemented what you need. To change the source parameters, one have to add them on the model. I just did that for kilonova. The AngularTimeSerieSources parameters are amplitude (derived from magabs->magobs->template given z) and theta. For theta, I now simply said it is randomly draw between 0 and 90 deg.

Please make sure theta is indeed defined in degree and it is indeed theta the parameter and not cos_theta. Fix if needed.

The kilonova as display here works starting version>=0.10.4

image

I am going to close this PR.

AkshayPanayada commented 9 months ago

Thank you

On Wed, 27 Sept 2023, 12:11 Mickael Rigault, @.***> wrote:

Closed #22 https://github.com/MickaelRigault/skysurvey/pull/22.

— Reply to this email directly, view it on GitHub https://github.com/MickaelRigault/skysurvey/pull/22#event-10483182312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZIAXID43UXNUDTWRKHCF73X4PDA7ANCNFSM6AAAAAA5IEDQVA . You are receiving this because you were mentioned.Message ID: @.***>