Midnighter / structurizr-python

A Python 3 port of Simon Brown's Structurizr diagrams-as-code architecture description tool.
https://structurizr.com/
Apache License 2.0
65 stars 16 forks source link

Issue 46: clean flake8 warnings #47

Closed yt-ms closed 3 years ago

yt-ms commented 3 years ago

Tidying up remaining flake8 warnings.


THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE Apache License v.2.0. YOU MAY OBTAIN A COPY OF THE LICENSE AT https://www.apache.org/licenses/LICENSE-2.0.

THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

codecov-io commented 3 years ago

Codecov Report

Merging #47 into devel will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel      #47   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files          64       64           
  Lines        1745     1745           
  Branches      151      151           
=======================================
  Hits         1485     1485           
  Misses        228      228           
  Partials       32       32           
Impacted Files Coverage Δ
src/structurizr/model/container_instance.py 63.63% <ø> (ø)
src/structurizr/model/deployment_node.py 63.15% <ø> (ø)
src/structurizr/model/element.py 100.00% <ø> (ø)
src/structurizr/model/enterprise.py 100.00% <ø> (ø)
src/structurizr/model/perspective.py 93.75% <ø> (ø)
src/structurizr/model/static_structure_element.py 78.57% <ø> (ø)
src/structurizr/view/animation.py 100.00% <ø> (ø)
src/structurizr/view/automatic_layout.py 69.56% <ø> (ø)
src/structurizr/view/branding.py 100.00% <ø> (ø)
src/structurizr/view/component_view.py 63.41% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8c6958...75428be. Read the comment docs.

Midnighter commented 3 years ago

I'm happy to merge these quickly and often. There is no need for you to fix all flake8 issues by yourself.

yt-ms commented 3 years ago

I'm happy to merge these quickly and often. There is no need for you to fix all flake8 issues by yourself.

That's OK, I've just blasted through them all - most were fairly mechanical so it didn't take long.