search

Midnighter / structurizr-python

A Python 3 port of Simon Brown's Structurizr diagrams-as-code architecture description tool.
https://structurizr.com/
Apache License 2.0
65 stars 16 forks source link

Better error messages for unknown initialization keyword arguments #60

Closed Midnighter closed 3 years ago

Midnighter commented 3 years ago

I couldn't push to your branch (PR #51 addressing #50) so I've made a new branch. This pushes the keyword argument handling down to AbstractBase where multiple inheritance should never be an issue. Let me know what you think about this approach @yt-ms

codecov-io commented 3 years ago

Codecov Report

Merging #60 (0c5069d) into devel (ba22ca8) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #60      +/-   ##
==========================================
+ Coverage   90.11%   90.14%   +0.03%     
==========================================
  Files          68       68              
  Lines        1953     1959       +6     
  Branches      171      173       +2     
==========================================
+ Hits         1760     1766       +6     
  Misses        173      173              
  Partials       20       20
Impacted Files Coverage Δ
src/structurizr/abstract_base.py 92.85% <100.00%> (+5.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba22ca8...0c5069d. Read the comment docs.