Midnighter / structurizr-python

A Python 3 port of Simon Brown's Structurizr diagrams-as-code architecture description tool.
https://structurizr.com/
Apache License 2.0
66 stars 16 forks source link

feat: add missing automatic layout params #88

Closed WLun001 closed 1 year ago

WLun001 commented 2 years ago

New to python, please help me to review @Midnighter

Midnighter commented 2 years ago

Actually, I took a look at the Java and the API definition and these two attributes are not part of the AutomaticLayout, it seems.

WLun001 commented 2 years ago

but i able to get it from the UI by inspecting the network tab

https://graphviz.structurizr.com/?view=id&resizePaper=true&rankDirection=TB&rankSeparation=300&nodeSeparation=300&margin=400
Midnighter commented 2 years ago

@simonbrowndotje can you comment on what the intention for resizePaper and margin is? From where should that be set?

WLun001 commented 2 years ago

I found on the java SDK and the docs

simonbrowndotje commented 2 years ago

Those are only currently used when manually initiating auto-layout from the Structurizr UI.

Screenshot 2022-01-24 at 11 26 03
Midnighter commented 2 years ago

@WLun001 I guess this first needs to be a feature request on the Structurizr API then before we can make changes here on the Python SDK.

WLun001 commented 2 years ago

I found on the java SDK and the docs

@Midnighter how about this? already on the Java SDK

Midnighter commented 2 years ago

The Python package only interacts with the web facing API. So we can only support what is possible through this API.

WLun001 commented 2 years ago

@Midnighter I see. So we have to wait the web facing APIs to update

Midnighter commented 1 year ago

I will close this as part of a clean up.