search

MiguelCastillo / Brackets-Themes

Brackets themes!
Other
138 stars 44 forks source link

Black cursor difficult to identify with sprint 43 #102

Closed simpleshadow closed 9 years ago

simpleshadow commented 9 years ago

I use the Monokai Dark Soda theme and it appears the latest sprint, 43, is ignoring the cursor color or has a new identifier we're not using. Now the cursor is black and is difficult to spot on the dark background.

MiguelCastillo commented 9 years ago

@simpleshadow Yeah, I am not sure that regression was introduced exactly. I have submitted a PR with brackets https://github.com/adobe/brackets/pull/9061. I am going to add a default one right now in the extension while we figure out what we do in brackets.

thanks for logging this one.

MiguelCastillo commented 9 years ago

Ok here we go https://github.com/MiguelCastillo/Brackets-Themes/commit/b7e0fd0af5663605ab00c003972f2612c15887bd

I published it in the registry a second ago. I will remove this temp hackery when we introduce a more sustainable fix in brackets.

simpleshadow commented 9 years ago

Ha! Nice. The ol' setTimeout(..., 0) trick. :wink: Thanks Miguel!

MiguelCastillo commented 9 years ago

I am not proud when I have to resort to that :D You bet!