search

MiguelCastillo / Brackets-Themes

Brackets themes!
Other
138 stars 44 forks source link

Theme custom styles get overridden #110

Closed sirnornur closed 9 years ago

sirnornur commented 9 years ago

untitled After latest update my .CodeMirror-selected, .CodeMirror-matchingbracket, .CodeMirror-matchingtag styles are forcedly overridden. This is very frustrating, especially after getting used to a favorite theme. I think this is related to "Auto detection of dark themes so that Brackets can do its dark theme specific styling." feature. How can I use my custom styles for .CodeMirror-selected, .CodeMirror-matchingbracket, .CodeMirror-matchingtag ?

MiguelCastillo commented 9 years ago

@sirnornur I am sorry for the inconvenience. What theme in particular is giving problems?

sirnornur commented 9 years ago

The theme I use is based on "Monokai" theme (I altered it little bit) which comes in brackets themes package. So you can see the same problem in "Monokai" theme too.

sirnornur commented 9 years ago

@MiguelCastillo, for example changing the following style in "Monokai" theme won't do anything:

.cm-s-monokai div.CodeMirror-selected {background: #49483E !important;}

Please test it. Thank you.

MiguelCastillo commented 9 years ago

@sirnornur is this the theme you are using? https://github.com/Brackets-Themes/Monokai Or the one shipped with the Themes extension? You can check the details in the package manager.

sirnornur commented 9 years ago

I'm using the one shipped with the Themes extension.

MiguelCastillo commented 9 years ago

@sirnornur Sorry for the slow response. I removed the !important; flag in resets.css that was causing the problem... https://github.com/MiguelCastillo/Brackets-Themes/commit/83c989f1c135915e4bbf7d056bc082e0e1719084

The changes are in master. Do you think you can give this a quick test to confirm this fixes the problem for you?

MiguelCastillo commented 9 years ago

@sirnornur All the tests I ran reflect that this issue is fixed. I am closing it... Please feel free to open new issues up if anything else comes up :)