search

MiguelCastillo / Brackets-Themes

Brackets themes!
Other
138 stars 44 forks source link

Copy a theme? #36

Closed lailoken closed 10 years ago

lailoken commented 10 years ago

I tried to copy one theme "Night Sky" to the custom folder and even though I do see the new theme, selecting it does not give the same theme as night sky... what am I doing wrong?

I don't want to start from a blank theme... I like your provided themes mostly, but I always tweak my comments to be more visible.

MiguelCastillo commented 10 years ago

Dropping it in theme folder should just work. Would you like to send me the theme so that I can give it a quick test?

lailoken commented 10 years ago

Well, just copy the night sky theme from the default app themes to the user folder?

Regards, Marius

On Tue, Jan 28, 2014 at 2:23 PM, Miguel Castillo @manchagnu < notifications@github.com> wrote:

Dropping it in theme folder should just work. Would you like to send me the theme so that I can give it a quick test?

Reply to this email directly or view it on GitHubhttps://github.com/MiguelCastillo/Brackets-Themes/issues/36#issuecomment-33473638 .

MiguelCastillo commented 10 years ago

@lailoken I tried copying the file over to the extensions theme directory and the theme was properly applied. The theme itself is called "Night" though, so I am not sure if we are talking about different themes.

Where exactly did you copy the theme from the app's directory to?

lailoken commented 10 years ago

I did:

~$ cd Library/Application\ Support/Brackets/

Brackets$ cp extensions/user/themesforbrackets/themes/night-sky.css custom\ themes/night.css

Then restarted, and chose 'Night' theme.

It does seem to change it 'slightly' when I select it, but does not look at all like the original 'Night Sky' theme.

Regards, Marius

On Wed, Jan 29, 2014 at 5:33 AM, Miguel Castillo @manchagnu < notifications@github.com> wrote:

@lailoken https://github.com/lailoken I tried copying the file over to the extensions theme directory and the theme was properly applied. The theme itself is called "Night" though, so I am not sure if we are talking about different themes.

Where exactly did you copy the theme from the app's directory to?

Reply to this email directly or view it on GitHubhttps://github.com/MiguelCastillo/Brackets-Themes/issues/36#issuecomment-33553480 .

MiguelCastillo commented 10 years ago

Hey, I think this issue might be for the other theme extension... This extension should show in your extensions/user as themes, not themesforbrackets. Can you verify that for me please? Maybe in the package.json. Let me know. I really don't have a night-sky.css in my themes

lailoken commented 10 years ago

Well, THAT was embarrassing.

Ok, I uninstalled that one and tried yours. And I found a default theme that suits my needs. (Aquaman)

I am just worried that updating the extension would nuke my custom themes... so not editing/adding any.

Regards, Marius

On Wed, Jan 29, 2014 at 3:07 PM, Miguel Castillo @manchagnu < notifications@github.com> wrote:

Hey, I think this issue might be for the other theme extension... This extension should show in your extensions/user as themes, not themesforbrackets. Can you verify that for me please? Maybe in the package.json. Let me know. I really don't have a night-sky.css in my themes

Reply to this email directly or view it on GitHubhttps://github.com/MiguelCastillo/Brackets-Themes/issues/36#issuecomment-33582599 .

MiguelCastillo commented 10 years ago

I am going to be adding a "users" folder so you can add your themes and not have them replaced everytime... Or, what would be even cooler... Submit your themes to me and I will publish them :)

lailoken commented 10 years ago

Oh, I don't think I'm creative enough... and I don't mind using any theme as long as it's legible.

My only requirement that usually deviates from the norm is that comments need to stand out above the rest. Basically comments are more important than most of the code for me. A habit I have since Delphi days.

Regards, Marius

On Wed, Jan 29, 2014 at 4:23 PM, Miguel Castillo @manchagnu < notifications@github.com> wrote:

I am going to be adding a "users" folder so you can add your themes and not have them replaced everytime... Or, what would be even cooler... Submit your themes to me and I will publish them :)

Reply to this email directly or view it on GitHubhttps://github.com/MiguelCastillo/Brackets-Themes/issues/36#issuecomment-33588120 .

MiguelCastillo commented 10 years ago

Meh, I think you are overthinking the whole creativity part of this... :)

Actually, the awesome guy that sent me aquaman created the theme because he needed comments to stand out too. Please feel free to make adjustments and share them with me. I can coordinate with the author of aquaman and maybe adjust it.

Delphi days, eh? Good ole days :D

-mc

lkcampbell commented 10 years ago

+1 on adding a users folder that doesn't get overwritten. I mean, if people want to send in new custom themes, that's great, too. But the users folder idea gives everyone two different options.

MiguelCastillo commented 10 years ago

@lkcampbell Adding a user folder was all you pal! Let me try to get that in tonight. The only issue is that the folder will just be orphaned if you ever decided to remove the extension... That's been my only hesitation all along.

How do you guys feel about that?

lkcampbell commented 10 years ago

I think it is fine, and, frankly, you don't really have any other choice.

The only way to address orphaned folders is for the core team to provide some sort of onExtensionUninstall() handler call as part of the core code. That way, extension developers could put optional clean up code in their extensions. You could remove your orphaned folder this way.

I actually did suggest this idea when I was working on the Extension reload code, but they wanted to keep it as simple as possible and try to remove the burden of cleanup from the extension developer.

Maybe it is time to revisit the idea?

MiguelCastillo commented 10 years ago

Yeah, I really never like leaving stuff orphaned, but as you said there is really no other choice with the current state of things.

Yeah, I think it would good to bring it up again to the core team to provide some optional hooks as you said.

DiegoAz commented 10 years ago

Hi @lailoken make me happy you liked the comment style from aquaman theme :).Although I make some changes and one of them for the comments.They don't stand out initially, when you hover over them they do it. That because I think in files with many comments stand out overmuch. Look the other changes but if you dont like you could do the necessary replacement. If you want you can use webapps like http://colllor.com/ or adobe kuler to make a theme, I dont know maybe you have some favourites colors and you want to watch everytime you coding. @MiguelCastillo I would like too the option of user folder with custom themes.

MiguelCastillo commented 10 years ago

Hey fellas, I have added logic to handle adding custom themes in a directory that will not get wiped out when updating the extension. The directory would need to be created with the name "themes" and it needs to go in the "extensions" directory.

Instructions:

  1. In Brackets, go to Help -> Show Extensions Folder.
  2. Create a folder called "themes" in there. It should be at the same level as user and disabled.
  3. Add your themes
  4. Close and open Brackets up again so that the Themes menu can be rebuilt.

Next step is to throw in a simple UI so that you can specify the directory that way... Maybe allowing multiple locations :)

But for now this should help do a quick proof of concept. Please update directly from the git... E.g. Install from url https://github.com/MiguelCastillo/Brackets-Themes, since the registry isn't updated yet.

-mc

lailoken commented 10 years ago

I have 0.2.1 and have copied a theme to the newly-created themes directory which is on the same level as the user and disabled directories.

But I did not see a new theme being available in the menu... what am I doing wrong?

Regards, Marius

On Thu, Jan 30, 2014 at 4:21 AM, Miguel Castillo @manchagnu < notifications@github.com> wrote:

Hey fellas, I have added logic to handle adding custom themes in a directory that will not get wiped out when updating the extension. The directory would need to be created with the name "themes" and it needs to go in the "extensions" directory.

Instructions:

  1. In Brackets, go to Help -> Show Extensions Folder.
  2. Create a folder called "themes" in there. It should be at the same level as user and disabled.
  3. Add your themes
  4. Close and open Brackets up again so that the Themes menu can be rebuilt.

Next step is to throw in a simple UI so that you can specify the directory that way... Maybe allowing multiple locations :)

But for now this should help do a quick proof of concept. Please update directly from the git... E.g. Install from url https://github.com/MiguelCastillo/Brackets-Themes, since the registry isn't updated yet.

-mc

Reply to this email directly or view it on GitHubhttps://github.com/MiguelCastillo/Brackets-Themes/issues/36#issuecomment-33654658 .

MiguelCastillo commented 10 years ago

Is the folder called theme or themes? It should be themes

MiguelCastillo commented 10 years ago

Also, you have to relaunch brackets so that it can re create the menu...

lailoken commented 10 years ago

I made sure of the directory:

~$ cd Library/ Library$ cd Application\ Support/Brackets/ Brackets$ ls cef_data extensions live-dev-profile Brackets$ cd extensions/ extensions$ ls disabled themes user extensions$ ls themes/ marius.css

I have the following installed: ThemesMiguel Castillo mahchagnu@gmail.comhttps://github.com/MiguelCastillo 0.2.1 CodeMirror and custom themes in Brackets

More info... https://github.com/MiguelCastillo/Brackets-Themes Remove Various improvementsDammmien https://github.com/Dammmien2.1.0 Add more informations in the status bar, lowercase and uppercase converter, super clipboard, button close all folders in file tree, files search

More info... https://github.com/Dammmien/brackets-various-improvements Remove WD MinimapBrian Adams brian@websiteduck.com (http://www.websiteduck.com) https://github.com/websiteduck2.2.3 The minimap shows a smaller version of your code at the right of the screen. It can be used to quickly scroll to a certain part of your file.

More info... https://github.com/websiteduck/brackets-wdminimap

And I've restarted a few times, yet I still get: (No marius.css)

[image: Inline image 1]

Regards, Marius

On Thu, Jan 30, 2014 at 4:23 PM, Miguel Castillo @manchagnu < notifications@github.com> wrote:

Also, you have to relaunch brackets so that it can re create the menu...

Reply to this email directly or view it on GitHubhttps://github.com/MiguelCastillo/Brackets-Themes/issues/36#issuecomment-33691628 .

MiguelCastillo commented 10 years ago

@lailoken I am very sorry... I didn't commit the one file that needed to be committed! It should hopefully work now. Thank you so much for testing.

-mc

DiegoAz commented 10 years ago

aha!. It now works. Thanks.

MiguelCastillo commented 10 years ago

Hey fellas, I am going to go ahead and close this one... I am actually going to try to get a preferences dialog in place to be more user friendly so that you can choose your own directory. https://github.com/MiguelCastillo/Brackets-Themes/issues/38

Thank you for your feedback!

lailoken commented 10 years ago

This makes more sense... I looked through the code (and changes in commits) and could not figure out how the themes directory was actually used.

Regards, Marius

On Fri, Jan 31, 2014 at 10:28 PM, Miguel Castillo @manchagnu < notifications@github.com> wrote:

Closed #36 https://github.com/MiguelCastillo/Brackets-Themes/issues/36.

Reply to this email directly or view it on GitHubhttps://github.com/MiguelCastillo/Brackets-Themes/issues/36 .

lailoken commented 10 years ago

Now I see the themes, can select them, but all custom themes don't seem to work at all. (no colors etc)

I have restarted Brackets.

(I've also removed all other extensions)

Regards, Marius

On Sat, Feb 1, 2014 at 9:11 AM, Marius Piedallu van Wyk lailoken@gmail.comwrote:

This makes more sense... I looked through the code (and changes in commits) and could not figure out how the themes directory was actually used.

Regards, Marius

On Fri, Jan 31, 2014 at 10:28 PM, Miguel Castillo @manchagnu < notifications@github.com> wrote:

Closed #36 https://github.com/MiguelCastillo/Brackets-Themes/issues/36.

Reply to this email directly or view it on GitHubhttps://github.com/MiguelCastillo/Brackets-Themes/issues/36 .

DiegoAz commented 10 years ago

For me works fine. Remember you have to change the classes of your custom file. If the file name is marius.css, the classes should be named marius. Ex: .cm-s-marius.CodeMirror

lailoken commented 10 years ago

oh... doh!

Fixed now.

PS: Does this not create some pollution? I've noticed that switching themes a lot seems to cause some to stop displaying correctly.

Regards, Marius

On Sun, Feb 2, 2014 at 1:34 PM, Diego Alfonso Álvarez Álvarez < notifications@github.com> wrote:

For me works fine. Remember you have to change the classes of your custom file. If the file name is marius.css, the classes should be named marius. Ex: .cm-s-marius.CodeMirror

Reply to this email directly or view it on GitHubhttps://github.com/MiguelCastillo/Brackets-Themes/issues/36#issuecomment-33907948 .

MiguelCastillo commented 10 years ago

Yeah, that pollution is caused by not properly defining your css rules. So, if a css rule does not contain .cm-s-marius, then Themes wont be able to clean it up.

The name of the theme is what CodeMirror (the text editor in Brackets) wants us to use in order to properly apply style.

Now, if you are going to be doing whole Brackets styling, then you could just use the name of your extension. e.g.

.marius .CodeMirror .marius ::scrollbars...

I should write I tutorial for this :)

-mc

MiguelCastillo commented 10 years ago

Ok guys, I have put in the first pass of the settings dialog to configure paths for your themes. For now, you can only change the three that Themes ships with. But soon I will be adding the ability to add/remove folders; soon is like maybe tomorrow :)

Please check it out and let me know what you think!

MiguelCastillo commented 10 years ago

Alright, I just made the necessary adjustments to allow adding/removing of paths for themes.