MiguelCastillo / Brackets-Themes

Brackets themes!
Other
138 stars 44 forks source link

Illegible text INS or OVR in many themes #72

Closed Denisov21 closed 10 years ago

Denisov21 commented 10 years ago

In this themes: Hammisidias, Pixie, Selenitic, Visual Studio 2012, Zanie.

You must to change the color of the words "INS" or "OVR" in the color same as "Spazi 4" (see picture). Thank you advantage! For solution #65

cattura

DiegoAz commented 10 years ago

the ID of that text is #status-overwrite

Denisov21 commented 10 years ago

@DiegoAz Hi, I have corrected these problems, I look @MiguelCastillo forward accept my PR! @DiegoAz Thank you for your help!

MiguelCastillo commented 10 years ago

Wow! This is really cool! Thank you :)

MiguelCastillo commented 10 years ago

@Denisov21 Thank you so much for your changes. One thing that would be really nice is if the formatting style would match the rest. Do you think you can that minor adjustment?

This is awesome. Wanna take on some more themes? :)

Denisov21 commented 10 years ago

@MiguelCastillo I realize that I have created a lot of PR; I'm sorry, I'm a beginner.

"One thing that would be really nice is if the formatting style would match the rest." Can you give me an example?

MiguelCastillo commented 10 years ago

@Denisov21 One PR for each theme is perfect.

So, I am only referring to formatting from

status-overwrite { color:#4BD278;}

To

status-overwrite {

 color:#4BD278;

}

Just so that the code looks consistent with the rest :)

Denisov21 commented 10 years ago

@MiguelCastillo Your idea about the formatting I really like, I just do not know how to change the PR that I've already posted!

MiguelCastillo commented 10 years ago

@Denisov21 Its easy, just check in the changes in the brackets you have created. They will automatically reflect in you PR

Denisov21 commented 10 years ago

@MiguelCastillo It's OK! Can you merge?

MiguelCastillo commented 10 years ago

@Denisov21 All perfect! Thank you so much