search

MiguelCastillo / Brackets-Themes

Brackets themes!
Other
138 stars 44 forks source link

Active line color & whitespace visibility #79

Closed dangelov closed 10 years ago

dangelov commented 10 years ago

screen shot 2014-06-17 at 6 30 44 pm

If you have Highlight Active Line and Show Whitespace on, the above is what you get. Are those not available for the themes to style, or are the themes themselves lacking the styling code for them?

MiguelCastillo commented 10 years ago

@dangelov It would be the themes lacking styles specific to what those extension are doing. It would be really hard for each theme to be created with extensions in mind. :/

Is what theme are you using? Would like to make a pull request?

dangelov commented 10 years ago

Pull request #80 handles the whitespace issue, but I could not find the css selector for the highlighted line. Any idea?

MiguelCastillo commented 10 years ago

Yeah, you are what you are looking at CodeMirror-activeline.

A trick for easier debugging of css is to comment out this line https://github.com/adobe/brackets/blob/master/src/styles/brackets_codemirror_override.less#L130

And then use the developer tools inspector to checkout the dom. :)

dangelov commented 10 years ago

Cool, thanks!

Updated the pull request with some additional styles. I think they work pretty well, have a look.

MiguelCastillo commented 10 years ago

@dangelov Awesome! I know this is a bit more work, bit it would be very cool if you the same for to the rest of the other dark themes? I already have a home for those overrides.

Take a look here how matching tags is done for each theme... Let me know if this is something you would be interested in doing. :) https://github.com/MiguelCastillo/Brackets-Themes/blob/master/reset.css

MiguelCastillo commented 10 years ago

@dangelov I somehow didn't even bother asking what exactly the issue is. Is it that the whitespace/tabs markers and active line outlines are too prominent?

MiguelCastillo commented 10 years ago

@dangelov I have lightened up the color a bit, so the whitespace characters should not be so distracting. Thanks for reporting this.

dangelov commented 10 years ago

Yes, the whitespace indicators and selection lines were too prominent and distracting.

I just updated to your latest changes and they're still too visible. Not sure what OS or display you use, but on a MacBook Pro the grey is too light and it's distracting. I'll probably end up using a modified version of Monokai to prevent the updates from overwriting my changes.

Thanks for your responses, help and fixes!

lkcampbell commented 10 years ago

@dangelov and @MiguelCastillo, the issue with Show Whitespace has been filed at https://github.com/DennisKehrig/brackets-show-whitespace/issues/10.

I don't think Dennis has a lot of time these days to address extension issues but a solution could be submitted that adds a color Extension Preference to Show Whitespace that could address it.