search

MiguelCastillo / Brackets-Themes

Brackets themes!
Other
138 stars 44 forks source link

Problems with folding #83

Open warpdesign opened 10 years ago

warpdesign commented 10 years ago

I'm not sure this is brackets-themes'fault, but there seem to be some glitches with some themes when using the brackets-code-folding extension (https://github.com/thehogfather/brackets-code-folding): begining of line is cropped.

Maybe I should report it on brackets-code-folding github too?

See attached screenshot. This happens with Zenburn & Wombat themes for example.

screen shot 2014-06-19 at 14 46 28

Doesn't happen with default theme: screen shot 2014-06-19 at 14 46 38

MiguelCastillo commented 10 years ago

@warpdesign Yeah, there are issue with how the gutter are being handled in Brackets itself, which negatively impact when themes and other extensions add padding. That's something that requires change in code folding but the real problem is in Brackets. If you log the issue with Brackets and reference this number, I will certainly provide my two cents

warpdesign commented 10 years ago

Ok. I'll do that then, thanks!

MiguelCastillo commented 10 years ago

@warpdesign if you havent logged it, let me take a quick look in more detail at this issue so that I can gather more concrete evidence... Let me ping you back to figure out when we do the next step. :)

MiguelCastillo commented 10 years ago

@warpdesign Meaning, dont log it just yet

warpdesign commented 10 years ago

Ok, I'll wait then, nop :) Thanks for the quick response!