search

MiguelCastillo / Brackets-Themes

Brackets themes!
Other
138 stars 44 forks source link

1.0.2 - Obsidian theme font not loading #87

Closed blah238 closed 10 years ago

blah238 commented 10 years ago

After uninstalling 0.8.2 and installing 1.0.2 the Obsidian theme comes up with a variable width serif font (like a narrow Times New Roman):

Screenshot 1

Commenting out https://github.com/MiguelCastillo/Brackets-Themes/blob/master/theme/obsidian.css#L3 fixes it, but as far as I can tell this line was always there?

Screenshot 2

MiguelCastillo commented 10 years ago

@blah238 It's supposed to be monaco... I am not sure where the Times New Roman look alike is coming from. Do you think you can do a quick check in the developer tools to see what font is being used?

blah238 commented 10 years ago

@MiguelCastillo this is all I was able to find out. Let me know how to find what you're asking for if that's not it.

Screenshot

MiguelCastillo commented 10 years ago

@blah238 Yeah monaco is the correct font. So, is the issue that you don't like the font or that obsidian was loading with a different font in 0.8.2?

Obsidian has had monaco since I created it...

blah238 commented 10 years ago

@MiguelCastillo The font in the second image is what it looked like at 0.8.2. The one in the first screenshot is clearly not Monaco, which is supposed to be a fixed-width sans-serif font according to: http://en.wikipedia.org/wiki/Monaco_%28typeface%29

I agree, it's strange since the CSS hasn't changed since the beginning.

BTW I am on Windows if that matters. Monaco is a Mac font.

blah238 commented 10 years ago

@MiguelCastillo Problem still exists at 1.0.3, but am able to work around it by using the Settings to set the font instead of editing the CSS.

MiguelCastillo commented 10 years ago

@blah238 Yeah, you are correct. Font type and line height were not persisted once brackets was restarted... Awesome catch!! I logged a separate bug for it https://github.com/MiguelCastillo/Brackets-Themes/issues/89. And it is already fixed. Thanks again :)

MiguelCastillo commented 10 years ago

@blah238 Its been a while, but I can no longer repro this issue. There were lots of changes I did in Brackets so I am not sure what resolved the issue. Closing, but let me know if there is anything else you think isn't correct. Thanks!