Themes settings not loading since v1.0.2 on Sprint 40

[ghost]

On my Mac yesterday I've updated to v1.0.2 and saw default theme was active.

When switching to Monokai Dark Soda my font, size and line height settings are not taken. I've checked the settings menu and saw an complete empty form.

The brackets settings file contains all information so I assume its not loaded or variable names have changed?

I copied all the values from Brackets settings file into the form and hit save button. The Brackets settings file have not changed for themes. After opening the settings menu again the form was empty - again.

Now here at work, on a Windows7 machine I have exactly the same behavior.

But I found a workaround. I have to close all open files and open them again. Edit: switching between files has also an effect - dont need to close and open files. -This works except for the Brackets settings file. But I have to do this on every re/-start of Brackets-.

[MiguelCastillo]

@fibric Yuk! This is really bad. It just seems like a corrupt preference file or another extension is just causing massive interference. Really sorry about this.

• What other extensions do you have installed?
• Do all other extension work correctly?
• Can you send me a screenshot of your extensions folder to see what else is in there?

Easy way to get to the state.json is to go through brackets Help menu and select "Show Extension Folder"

[ghost]

This is the console output from Brackets directly after start.

I guess the font size sync extensions has some problems now. But its not updated since long time already.

getPreferenceStorage is called with client ID '/Users/fibric/Library/Application Support/Brackets/extensions/user/brackets-fontsize-sync/main.js,' use PreferencesManager.definePreference instead. at Object.getPreferenceStorage (/preferences/PreferencesManager.js:126:32) at Object. ( file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/brackets-fontsize-sync/main.js:25:42 ) /utils/DeprecationWarning.js:85 http://localhost:9234/utils/DeprecationWarning.js Use brackets.getModule("thirdparty/CodeMirror2/lib/codemirror") instead of global CodeMirror. at Object.defineProperty.get (/brackets.js:115:32) at Object. ( file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/com.tregusti.gherkin/main.js:139:3 ) /utils/DeprecationWarning.js:85 http://localhost:9234/utils/DeprecationWarning.js Use brackets.getModule("thirdparty/CodeMirror2/lib/codemirror") instead of global CodeMirror. at Object.defineProperty.get (/brackets.js:115:32) at Object. ( file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/globals/main.js:387:3 ) /utils/DeprecationWarning.js:85 http://localhost:9234/utils/DeprecationWarning.js getPreferenceStorage is called with client ID 'me.drewh.jsbeautify-autosave,' use PreferencesManager.definePreference instead. at Object.getPreferenceStorage (/preferences/PreferencesManager.js:126:32) at Object. ( file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/brackets-beautify/main.js:253:42 ) /utils/DeprecationWarning.js:85 http://localhost:9234/utils/DeprecationWarning.js getValue is called to get preference 'enabled,' use PreferencesManager.get instead. at PreferenceStorage.getValue (/preferences/PreferenceStorage.js:128:28) at Object. ( file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/brackets-beautify/main.js:257:31 ) /utils/DeprecationWarning.js:85 http://localhost:9234/utils/DeprecationWarning.js setValue is called to set preference 'enabled,' use PreferencesManager.set instead. at PreferenceStorage.setValue (/preferences/PreferenceStorage.js:115:28) at toggle ( file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/brackets-beautify/main.js:249:21) at Object. ( file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/brackets-beautify/main.js:283:5 ) /utils/DeprecationWarning.js:85 http://localhost:9234/utils/DeprecationWarning.js getPreferenceStorage is called with client ID 'bracketsTerminal.settings,' use PreferencesManager.definePreference instead. at Object.getPreferenceStorage (/preferences/PreferencesManager.js:126:32) at _init ( file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/brackets-terminal/src/settings.js:20:38) at Object. ( file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/brackets-terminal/src/settings.js:53:5 ) /utils/DeprecationWarning.js:85 http://localhost:9234/utils/DeprecationWarning.js Failed to load resource file:///Applications/Brackets.app/Contents/www/img/glyphicons-halflings.png Failed to load resource http://localhost:8080/socket.io/1/?t=1403729509254 getPreferenceStorage is called with client ID '/Users/fibric/Library/Application Support/Brackets/extensions/user/brackets-workspaces/libraries/MainWindow/MainWindowManager.js,' use PreferencesManager.definePreference instead. at Object.getPreferenceStorage (/preferences/PreferencesManager.js:126:32) at Object. ( file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/brackets-workspaces/libraries/MainWindow/MainWindowManager.js:50:54 ) /utils/DeprecationWarning.js:85 http://localhost:9234/utils/DeprecationWarning.js [theseus] fsm: -> waitingForApp fsm.js:35 [brackets-dash] init main.js:42 AppInit main.js:523 [theseus] fsm: -> disconnected fsm.js:35 NotFound main.js:104 Failed to load resource file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/brackets-morecsscodehints/styles/brackets-css-hints.css

1. Recursive tests with the same name are not supported. Timer name: CodeInspection: /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117
2. Recursive tests with the same name are not supported. Timer name: CodeInspection 'JSCS': /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117
3. Recursive tests with the same name are not supported. Timer name: CodeInspection 'JSHint': /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117
4. Recursive tests with the same name are not supported. Timer name: CodeInspection: /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117
5. Recursive tests with the same name are not supported. Timer name: CodeInspection 'JSCS': /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117
6. Recursive tests with the same name are not supported. Timer name: CodeInspection 'JSHint': /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117
7. Recursive tests with the same name are not supported. Timer name: CodeInspection: /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117
8. Recursive tests with the same name are not supported. Timer name: CodeInspection 'JSCS': /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117
9. Recursive tests with the same name are not supported. Timer name: CodeInspection 'JSHint': /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117

Failed to load resource file:///Users/fibric/Library/Application%20Support/Brackets/extensions/user/fdecampredon.brackets-epic-linter/style/underline.svg Fatal failure Object linterReporter.js:212

1. Recursive tests with the same name are not supported. Timer name: CodeInspection: /Users/fibric/Projects/javascript/vm/js/components/VoteApp.react.js ErrorNotification.js:117
2. Recursive tests with the same name are not supported. Timer name: CodeInspection 'JSCS': /Users/fibric/Projects/javascript/vm/js/components/VoteApp.react.js ErrorNotification.js:117
3. Recursive tests with the same name are not supported. Timer name: CodeInspection 'JSHint': /Users/fibric/Projects/javascript/vm/js/components/VoteApp.react.js ErrorNotification.js:117

Fatal failure Object linterReporter.js:212

1. Recursive tests with the same name are not supported. Timer name: CodeInspection: /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117
2. Recursive tests with the same name are not supported. Timer name: CodeInspection 'JSCS': /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117
3. Recursive tests with the same name are not supported. Timer name: CodeInspection 'JSHint': /Users/fibric/Projects/javascript/vm/js/components/Header.react.js ErrorNotification.js:117

Fatal failure Object linterReporter.js:212

On Wed, Jun 25, 2014 at 2:38 PM, Miguel Castillo @manchagnu < notifications@github.com> wrote:

@fibric https://github.com/fibric Yuk! This is really bad. It just seems like a corrupt preference file or another extension is just causing massive interference. Really sorry about this.

• What other extensions do you have installed?
• Do all other extension work correctly?
• Can you send me a screenshot of your extensions folder to see what else is in there?

Easy way to get to the state.json is to go through brackets Help menu and select "Show Extension Folder"

— Reply to this email directly or view it on GitHub https://github.com/MiguelCastillo/Brackets-Themes/issues/88#issuecomment-47095016 .

total 40 -rw-r--r--@ 1 fibric staff 18K Jun 25 22:50 .DS_Store drwxr-xr-x 7 fibric staff 238B May 8 23:53 asgerf.bracket-rename drwxr-xr-x 7 fibric staff 238B Jun 1 19:45 beldar.auto-brackets drwxr-xr-x 10 fibric staff 340B May 8 23:53 brackets-beautify drwxr-xr-x 9 fibric staff 306B Jun 22 03:30 brackets-boilerplate drwxr-xr-x 12 fibric staff 408B May 25 21:26 brackets-code-folding drwxr-xr-x 6 fibric staff 204B May 9 00:38 brackets-coffeelint drwxr-xr-x 5 fibric staff 170B May 9 00:38 brackets-fontsize-sync drwxr-xr-x 8 fibric staff 272B Jun 16 19:46 brackets-html5codehints drwxr-xr-x 7 fibric staff 238B Jun 16 19:46 brackets-morecsscodehints drwxr-xr-x 12 fibric staff 408B May 20 17:07 brackets-ruler drwxr-xr-x 7 fibric staff 238B May 29 03:35 brackets-sort-text drwxr-xr-x 13 fibric staff 442B May 14 08:06 brackets-terminal drwxr-xr-x 16 fibric staff 544B Jun 22 03:30 brackets-workspaces drwxr-xr-x 11 fibric staff 374B Jun 22 03:30 bracketstoix drwxr-xr-x 6 fibric staff 204B May 27 23:57 camden.bracketsdash drwxr-xr-x 8 fibric staff 272B Jun 22 03:30 camden.caniuse drwxr-xr-x 9 fibric staff 306B Jun 6 22:49 camden.jshint drwxr-xr-x 5 fibric staff 170B May 31 10:16 com.hamdanjaveed.joinlines drwxr-xr-x 8 fibric staff 272B May 29 03:37 com.tregusti.gherkin drwxr-xr-x 6 fibric staff 204B May 29 12:07 dkehrig.show-whitespace drwxr-xr-x 6 fibric staff 204B May 2 20:10 dsbonev.whitespace-normalizer drwxr-xr-x 10 fibric staff 340B Jun 23 04:07 fdecampredon.brackets-epic-linter drwxr-xr-x 11 fibric staff 374B Jun 6 22:49 fede91.brackets-preferences-ui drwxr-xr-x 6 fibric staff 204B Jun 3 18:59 globals drwxr-xr-x 10 fibric staff 340B Jun 6 22:49 globexdesigns.brackets-jscs drwxr-xr-x 11 fibric staff 374B Jun 9 12:43 gruehle.markdown-preview drwxr-xr-x 7 fibric staff 238B Jun 22 03:30 insya.newdocument drwxr-xr-x 20 fibric staff 680B Jun 14 17:15 interactive-linter drwxr-xr-x 10 fibric staff 340B Jun 10 18:32 ivogabe.icons drwxr-xr-x 11 fibric staff 374B May 12 21:01 jeffbooher.new-project drwxr-xr-x 12 fibric staff 408B May 9 00:38 le717.html-skeleton drwxr-xr-x 8 fibric staff 272B May 29 03:33 martypenner.autosave-files-on-window-blur drwxr-xr-x 8 fibric staff 272B May 2 20:08 opensourceportfolio.brackets-cut-line drwxr-xr-x 5 fibric staff 170B May 2 20:09 pflynn.copy-as-html drwxr-xr-x 9 fibric staff 306B May 2 20:09 pflynn.regex-editor drwxr-xr-x 10 fibric staff 340B Jun 22 03:30 quickdocsjs drwxr-xr-x 13 fibric staff 442B May 29 03:26 spell-check drwxr-xr-x 31 fibric staff 1.0K Jun 9 12:43 ternific drwxr-xr-x 17 fibric staff 578B Jun 23 15:12 themes drwxr-xr-x 10 fibric staff 340B May 9 00:37 theseus drwxr-xr-x 9 fibric staff 306B Jun 16 19:46 tjeffree.extensionhighlighter drwxr-xr-x 9 fibric staff 306B Jun 13 20:28 ws-sanitizer drwxr-xr-x 5 fibric staff 170B Jun 6 22:49 y0nnyy.specialchars drwxr-xr-x 17 fibric staff 578B Jun 15 20:25 zaggino.brackets-git drwxr-xr-x 6 fibric staff 204B Jun 16 19:46 zeid.autosave-on-view-change

[MiguelCastillo]

@fibric Holy smokes you got lots of extensions!! So, this is going to be painful to debug unless we narrow down what's the source of the problem. My gut feeling is that one or more of those extension is just not playing nice.

So, here is what I suggest. Rename the folder user to user.bk. Create another user folder and only install themes. Let's just make sure that works. We will need to continue to add extensions until we find who is the culprit. We can figure what to do at that point. :/

[ghost]

@manchagnu

Ok here at company I start with what you've suggested.

Renamed user folder. Created a new user folder.

https://mail.google.com/mail/u/0/?ui=2&ik=c18f4fe47d&view=att&th=146d89e827a06ff6&attid=0.1&disp=safe&realattid=f_hww6gn5x0&zw 2014-06-26_15-18-05.png https://mail.google.com/mail/u/0/?ui=2&ik=c18f4fe47d&view=att&th=146d89e827a06ff6&attid=0.1&disp=safe&realattid=f_hww6gn5x0&zw (85K) https://mail.google.com/mail/u/0/?ui=2&ik=c18f4fe47d&view=att&th=146d89e827a06ff6&attid=0.1&disp=safe&realattid=f_hww6gn5x0&zw

Started Brackets and installed only Themes extension & restarted Brackets as it is required to do so.

This is how it looks now.

https://mail.google.com/mail/u/0/?ui=2&ik=c18f4fe47d&view=att&th=146d8a4ee641366a&attid=0.2&disp=safe&realattid=f_hww6psgd1&zw 2014-06-26_16-41-33.png https://mail.google.com/mail/u/0/?ui=2&ik=c18f4fe47d&view=att&th=146d8a4ee641366a&attid=0.2&disp=safe&realattid=f_hww6psgd1&zw (179K) https://mail.google.com/mail/u/0/?ui=2&ik=c18f4fe47d&view=att&th=146d8a4ee641366a&attid=0.2&disp=safe&realattid=f_hww6psgd1&zw

I see a new variable telling which Theme is used.

The font size of 20px is not used.

The line height of 1.3em is not used.

My beloved Fantasque Sans Mono font also not used.

Cheers

PS: I'll go home now and try the same at home on my mac.

On Wed, Jun 25, 2014 at 11:07 PM, Miguel Castillo @manchagnu < notifications@github.com> wrote:

@fibric https://github.com/fibric Holy smokes you got lots of extensions!! So, this is going to be painful to debug unless we narrow down what's the source of the problem. My gut feeling is that one or more of those extension is just not playing nice.

So, here is what I suggest. Rename the folder user to user.bk. Create another user folder and only install themes. Let's just make sure that works. We will need to continue to add extensions until we find who is the culprit. We can figure what to do at that point. :/

— Reply to this email directly or view it on GitHub https://github.com/MiguelCastillo/Brackets-Themes/issues/88#issuecomment-47158867 .

[ghost]

@manchagnu

And this how it looks now on OS X.

Did almost the same here. Duplicated the folder, cleared the user folder, started Brackets, installed Themes extension (monokai dark soda was applied instantly, restarted Brackets, opened Themes settings window.

Screenshot 2014-06-26 21.54.03.png

And like already on windows, I see to times a brackets theme variable which contains information about monokai dark soda.

"brackets-themes-extension.themes": [ "monokai-dark-soda" ]

"brackets-themes.theme": [ "monokai-dark-soda" ]

Denny Trebbin Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday 26 June 2014 at 16:50, Denny Trebbin wrote:

@manchagnu Ok here at company I start with what you've suggested. Renamed user folder. Created a new user folder.

2014-06-26_15-18-05.png (https://mail.google.com/mail/u/0/?ui=2&ik=c18f4fe47d&view=att&th=146d89e827a06ff6&attid=0.1&disp=safe&realattid=f_hww6gn5x0&zw) (85K) (https://mail.google.com/mail/u/0/?ui=2&ik=c18f4fe47d&view=att&th=146d89e827a06ff6&attid=0.1&disp=safe&realattid=f_hww6gn5x0&zw)>
Started Brackets and installed only Themes extension & restarted Brackets as it is required to do so. This is how it looks now.

2014-06-26_16-41-33.png (https://mail.google.com/mail/u/0/?ui=2&ik=c18f4fe47d&view=att&th=146d8a4ee641366a&attid=0.2&disp=safe&realattid=f_hww6psgd1&zw) (179K) (https://mail.google.com/mail/u/0/?ui=2&ik=c18f4fe47d&view=att&th=146d8a4ee641366a&attid=0.2&disp=safe&realattid=f_hww6psgd1&zw)>
I see a new variable telling which Theme is used. The font size of 20px is not used. The line height of 1.3em is not used. My beloved Fantasque Sans Mono font also not used.

Cheers

PS: I'll go home now and try the same at home on my mac.

On Wed, Jun 25, 2014 at 11:07 PM, Miguel Castillo @manchagnu <notifications@github.com (mailto:notifications@github.com)> wrote:

@fibric (https://github.com/fibric) Holy smokes you got lots of extensions!! So, this is going to be painful to debug unless we narrow down what's the source of the problem. My gut feeling is that one or more of those extension is just not playing nice.
So, here is what I suggest. Rename the folder user to user.bk. Create another user folder and only install themes. Let's just make sure that works. We will need to continue to add extensions until we find who is the culprit. We can figure what to do at that point. :/

— Reply to this email directly or view it on GitHub (https://github.com/MiguelCastillo/Brackets-Themes/issues/88#issuecomment-47158867).

Attachments:

• 2014-06-26_15-18-05.png
• 2014-06-26_16-41-33.png

[MiguelCastillo]

@fibric thank you so much for your troubleshooting! But unfortunately none the screenshots are not coming through. So I am not 100% if themes is working or not... :/ Do you think you can try again or even email them to me at manchagnu@gmail.com?

So, one change I made to themes this release was to store preferences in brackets-themes-extension because the upcoming themes in brackets core will probably be using brackets-themes.

[blah238]

Not sure if it's the same problem, but on two different Windows PCs, I was not able to update Brackets-Themes from 0.8.2 to 1.0.2 without blowing away all the Brackets-Themes related stuff from my AppData/Brackets folder (including within config files). Is there a way to go back and install 0.8.2 to try again and reproduce?

[ghost]

@blah238 you properly can download this revision https://github.com/MiguelCastillo/Brackets-Themes/tree/0dc9543b6584cf899d420d49b85d6de1eefecad9 then unzip it in brackets/extensions/theme The Brackets plugin registry has no public history of versions as far as I know.

[ghost]

@MiguelCastillo I have changed the variable names in my config to 'brackets-themes-extension...' and except custom scrollbars all values are now shown in dialog.

And after restarting Brackets, finally font size, font type and line height are taken :+1:

[MiguelCastillo]

@fibric @blah238 It just dawned on me! The reason why this is completely failing is because Brackets preferences system will do an index of in the key... I only change the preferences to include "extension" at the end, so Brackets continued to give me the old settings, which have changed a little bit. Yikes! I will submit a fix for this in shortly.

Guys, thank you so much for helping. Really appreciate it.

[MiguelCastillo]

@fibric What did you use to overlay those labels on the screenshot? That looks really nice. Far better than my red circles and boxes.

[ghost]

Its done with Skitch.app from Evernote. But it was way better before Evernote has taken the app...

Denny Trebbin Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Friday 27 June 2014 at 16:18, Miguel Castillo @manchagnu wrote:

@fibric (https://github.com/fibric) What did you use to overlay those labels on the screenshot? That looks really nice. Far better than my red circles and boxes.

— Reply to this email directly or view it on GitHub (https://github.com/MiguelCastillo/Brackets-Themes/issues/88#issuecomment-47350210).

[MiguelCastillo]

@fibric @blah238 I just checked in a fix for this. Thank you guys for helping out! It's currently checked into the main branch, so feel free to test before I publish to the extension registry.

@blah238 I am going to look into adding tags to make easier for people to get specific release point of themes. :)

[MiguelCastillo]

@fibric @blah238 Alright, I just published to the extension registry

[MiguelCastillo]

@blah238 I create releases (tags) as far back a 0.8.0 so that we can easily access them. https://github.com/MiguelCastillo/Brackets-Themes/releases

[blah238]

@MiguelCastillo looks like the settings are working now! FYI the registry version number still says 1.0.2 though.

[MiguelCastillo]

@blah238 weird, the registry would not allow me update without incrementing the version...

Here is what it looks like on mine end...

[blah238]

@MiguelCastillo Huh, you are right. Maybe I was expecting it to show the new version number before I upgraded to it. My bad.

[blah238]

@MiguelCastillo BTW, please consider using the changelog functionality that Brackets-Git uses, I find it very useful to see what's new!

[blah238]

@MiguelCastillo May have spoken slightly too soon -- when I restart Brackets, the Font setting is ignored and I have to update the Settings to get it to apply again. This happens with the Default theme as well as Obsidian. The Line Spacing setting seems to have the same problem. The Size setting seems to be correctly applied at startup though.

[blah238]

@MiguelCastillo Looks like 1.0.4 fixed it! Thanks!