search

MiguelCastillo / Brackets-Themes

Brackets themes!
Other
138 stars 44 forks source link

Start/End Tag Highlights #93

Closed rayinc8 closed 10 years ago

rayinc8 commented 10 years ago

What happened tot he highlighting of the start/end tags in the latest release? Reverted back to the old version (0.7.9) because of it.

MiguelCastillo commented 10 years ago

@rayinc8 What theme in particular is causing issues? Do you think you can provide a screenshots to show the problem?

I made changes in darks themes to have a more mellow tag highlighting because the text wasn't very legible. Maybe you are looking for something more prominent. Let me know how we can make it better.

-mc

rayinc8 commented 10 years ago

@MiguelCastillo The theme that I've been seeing the issue is on Tomorrow Night Eighties. It's actually happening to the other themes as well after the update.

theme_beforeafter

<head> was selected in both instances.

-R

MiguelCastillo commented 10 years ago

@rayinc8 Awesome dude, thanks! I will take care of it in the next day or two so that you can go back to latest :)

santiagofn commented 10 years ago

Hi, @MiguelCastillo, @rayinc8 . I can confirm this is still happening on version 1.0.4. I tried various themes (Monokai Soda Dark, Obsidian, etc. etc.) and the highlighting isn't working in none.

MiguelCastillo commented 10 years ago

@santiagofn @rayinc8 Hey folks, I have been absent for a long time... Sorry about that. But I have just added some default dark theme colors that match those of brackets default dark theme colors. This includes matching tags. If you would be really cool if you let me know if these colors are good for you guys or what colors in particular work better.

MiguelCastillo commented 10 years ago

fyi https://github.com/MiguelCastillo/Brackets-Themes/commit/297e626251cdfec7f865eadedbc019de4b08eb57

santiagofn commented 10 years ago

@MiguelCastillo, thanks! I couldn't test the colors you proposed, but I'm all confidence. ;)